Skip to content

Fix every third list item broken#2318

Merged
styfle merged 2 commits intomarkedjs:masterfrom
calculuschild:FixThirdSublistBroken
Dec 9, 2021
Merged

Fix every third list item broken#2318
styfle merged 2 commits intomarkedjs:masterfrom
calculuschild:FixThirdSublistBroken

Conversation

@calculuschild
Copy link
Copy Markdown
Contributor

@calculuschild calculuschild commented Dec 9, 2021

Marked version:

4.0.6

Description

Fixes #2314

#2302 mistakenly used list.loose as a flag to end list items early if they start with two blank lines. Technically that is a different scenario from being "loose", so legitimate loose lists were also hitting that flag and prematurely ending the list after the second item. This PR just adds a separate flag endEarly to handle that case.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 9, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/DHNZFHw9M4ntqboD5p5STLypQVHA
✅ Preview: https://markedjs-git-fork-calculuschild-fixthirdsublistbroken-markedjs.vercel.app

styfle
styfle approved these changes Dec 9, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle styfle merged commit 346b162 into markedjs:master Dec 9, 2021
github-actions bot pushed a commit that referenced this pull request Dec 9, 2021
@semantic-release-bot
chore(release): 4.0.7 [skip ci]
9b5e264 
## [4.0.7](v4.0.6...v4.0.7) (2021-12-09)

### Bug Fixes

* Fix every third list item broken ([#2318](#2318)) ([346b162](346b162)), closes [#2314](#2314)
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 10, 2021

🎉 This PR is included in version 4.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sync-by-unito sync-by-unito bot mentioned this pull request Jan 22, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Jun 11, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 29, 2022
Open
@ekmixon ekmixon mentioned this pull request Nov 29, 2023
Open
Logiclayer1111 pushed a commit to Logiclayer1111/marked that referenced this pull request Apr 20, 2026
@semantic-release-bot
chore(release): 4.0.7 [skip ci]
e8073e8 
## [4.0.7](markedjs/marked@v4.0.6...v4.0.7) (2021-12-09)

### Bug Fixes

* Fix every third list item broken ([#2318](markedjs/marked#2318)) ([b0f1662](markedjs/marked@b0f1662)), closes [#2314](markedjs/marked#2314)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UziTech UziTech UziTech approved these changes

@styfle styfle styfle approved these changes

@davisjam davisjam Awaiting requested review from davisjam

@joshbruce joshbruce Awaiting requested review from joshbruce

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sub-list items which are multiples of 3 are wrapped with pre/code blocks in version 4.0.6

3 participants

@calculuschild @UziTech @styfle