fix: Fix more Escape conflicts#2838
Merged
UziTech merged 3 commits intomarkedjs:masterfrom Jun 7, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
UziTech
approved these changes
Jun 6, 2023
Member
UziTech
left a comment
There was a problem hiding this comment.
According to recheck those regexps are safe. 👍
github-actions bot
pushed a commit
that referenced
this pull request
Jun 7, 2023
## [5.0.5](v5.0.4...v5.0.5) (2023-06-07) ### Bug Fixes * Fix more Escape conflicts ([#2838](#2838)) ([f879a23](f879a23))
Logiclayer1111
pushed a commit
to Logiclayer1111/marked
that referenced
this pull request
Apr 20, 2026
## [5.0.5](markedjs/marked@v5.0.4...v5.0.5) (2023-06-07) ### Bug Fixes * Fix more Escape conflicts ([#2838](markedjs/marked#2838)) ([96d26b8](markedjs/marked@96d26b8))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked version: 5.0.4
Markdown flavor: GFM
Description
What was attempted
Literally the only cause of #2280 failing was because
\was not included in the punctuation list. I added that, and undid the complex solution from #2627.Also changed the "mask out escaped EmStrong" code to mask out all escaped tokens, which handled the new test case
_\\_where the backslash is itself escaped. Could have been handled by a more complex escapedEmStrong regex, but this solution I think can apply to a few other locations where escapes come up, in a future cleanup PR, and doesn't appear to add any slowdown compared to the current solution.Contributor
Committer
In most cases, this should be a different person than the contributor.