Skip to content

fix typo#2870

Merged
UziTech merged 1 commit intomarkedjs:masterfrom
alexfauquette:fix-typo
Jul 7, 2023
Merged

fix typo#2870
UziTech merged 1 commit intomarkedjs:masterfrom
alexfauquette:fix-typo

Conversation

@alexfauquette
Copy link
Copy Markdown
Contributor

@alexfauquette alexfauquette commented Jul 5, 2023

Marked version:

Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a

Description

  • Fixes #### (if fixing a known issue; otherwise, describe issue using the following format)

When throwing an error it adds a message with a wrong link to the repository.
Detected because it make test fail since the error message is modified

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 2:31pm

UziTech
UziTech approved these changes Jul 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💯

@UziTech UziTech requested review from calculuschild and styfle July 7, 2023 05:53
styfle
styfle approved these changes Jul 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@styfle
Copy link
Copy Markdown
Member

styfle commented Jul 7, 2023

I'm also wondering if we should remove the period at the end since it might make the link 404. For example:

https://github.com/markedjs/marked.

@UziTech UziTech merged commit e6a7184 into markedjs:master Jul 7, 2023
github-actions bot pushed a commit that referenced this pull request Jul 7, 2023
@semantic-release-bot
chore(release): 5.1.1 [skip ci]
19b8ced 
## [5.1.1](v5.1.0...v5.1.1) (2023-07-07)

### Bug Fixes

* fix typo ([#2870](#2870)) ([e6a7184](e6a7184))
@X-oss-byte X-oss-byte mentioned this pull request May 24, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 7, 2024
Open
Logiclayer1111 pushed a commit to Logiclayer1111/marked that referenced this pull request Apr 20, 2026
@semantic-release-bot
chore(release): 5.1.1 [skip ci]
48a87fa 
## [5.1.1](markedjs/marked@v5.1.0...v5.1.1) (2023-07-07)

### Bug Fixes

* fix typo ([#2870](markedjs/marked#2870)) ([819ab65](markedjs/marked@819ab65))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UziTech UziTech UziTech approved these changes

@styfle styfle styfle approved these changes

@calculuschild calculuschild Awaiting requested review from calculuschild

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexfauquette @styfle @UziTech