fix(TS): Error impls now properly type this (#4978)

benlesh · web-flow · commit 7606dc700155 · 2019-08-26T13:14:33.000-05:00
Fixes an issue with TypeScript compilation in more strict environments.
diff --git a/src/internal/util/ArgumentOutOfRangeError.ts b/src/internal/util/ArgumentOutOfRangeError.ts
@@ -6,7 +6,7 @@ export interface ArgumentOutOfRangeErrorCtor {
 }
 
 const ArgumentOutOfRangeErrorImpl = (() => {
-  function ArgumentOutOfRangeErrorImpl(this: any) {
+  function ArgumentOutOfRangeErrorImpl(this: Error) {
     Error.call(this);
     this.message = 'argument out of range';
     this.name = 'ArgumentOutOfRangeError';
diff --git a/src/internal/util/EmptyError.ts b/src/internal/util/EmptyError.ts
@@ -6,7 +6,7 @@ export interface EmptyErrorCtor {
 }
 
 const EmptyErrorImpl = (() => {
-  function EmptyErrorImpl(this: any) {
+  function EmptyErrorImpl(this: Error) {
     Error.call(this);
     this.message = 'no elements in sequence';
     this.name = 'EmptyError';
diff --git a/src/internal/util/ObjectUnsubscribedError.ts b/src/internal/util/ObjectUnsubscribedError.ts
@@ -6,7 +6,7 @@ export interface ObjectUnsubscribedErrorCtor {
 }
 
 const ObjectUnsubscribedErrorImpl = (() => {
-  function ObjectUnsubscribedErrorImpl(this: any) {
+  function ObjectUnsubscribedErrorImpl(this: Error) {
     Error.call(this);
     this.message = 'object unsubscribed';
     this.name = 'ObjectUnsubscribedError';
diff --git a/src/internal/util/TimeoutError.ts b/src/internal/util/TimeoutError.ts
@@ -6,7 +6,7 @@ export interface TimeoutErrorCtor {
 }
 
 const TimeoutErrorImpl = (() => {
-  function TimeoutErrorImpl(this: any) {
+  function TimeoutErrorImpl(this: Error) {
     Error.call(this);
     this.message = 'Timeout has occurred';
     this.name = 'TimeoutError';
diff --git a/src/internal/util/UnsubscriptionError.ts b/src/internal/util/UnsubscriptionError.ts
@@ -7,13 +7,13 @@ export interface UnsubscriptionErrorCtor {
 }
 
 const UnsubscriptionErrorImpl = (() => {
-  function UnsubscriptionErrorImpl(this: any, errors: any[]) {
+  function UnsubscriptionErrorImpl(this: Error, errors: (Error|string)[]) {
     Error.call(this);
     this.message = errors ?
       `${errors.length} errors occurred during unsubscription:
 ${errors.map((err, i) => `${i + 1}) ${err.toString()}`).join('\n  ')}` : '';
     this.name = 'UnsubscriptionError';
-    this.errors = errors;
+    (this as any).errors = errors;
     return this;
   }
 
@@ -26,4 +26,4 @@ ${errors.map((err, i) => `${i + 1}) ${err.toString()}`).join('\n  ')}` : '';
  * An error thrown when one or more errors have occurred during the
  * `unsubscribe` of a {@link Subscription}.
  */
-export const UnsubscriptionError: UnsubscriptionErrorCtor = UnsubscriptionErrorImpl as any;
+export const UnsubscriptionError: UnsubscriptionErrorCtor = UnsubscriptionErrorImpl as any;

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ export interface ArgumentOutOfRangeErrorCtor {`
`6`	`6`	`}`
`7`	`7`
`8`	`8`	`const ArgumentOutOfRangeErrorImpl = (() => {`
`9`		`- function ArgumentOutOfRangeErrorImpl(this: any) {`
	`9`	`+ function ArgumentOutOfRangeErrorImpl(this: Error) {`
`10`	`10`	`Error.call(this);`
`11`	`11`	`this.message = 'argument out of range';`
`12`	`12`	`this.name = 'ArgumentOutOfRangeError';`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ export interface EmptyErrorCtor {`
`6`	`6`	`}`
`7`	`7`
`8`	`8`	`const EmptyErrorImpl = (() => {`
`9`		`- function EmptyErrorImpl(this: any) {`
	`9`	`+ function EmptyErrorImpl(this: Error) {`
`10`	`10`	`Error.call(this);`
`11`	`11`	`this.message = 'no elements in sequence';`
`12`	`12`	`this.name = 'EmptyError';`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ export interface ObjectUnsubscribedErrorCtor {`
`6`	`6`	`}`
`7`	`7`
`8`	`8`	`const ObjectUnsubscribedErrorImpl = (() => {`
`9`		`- function ObjectUnsubscribedErrorImpl(this: any) {`
	`9`	`+ function ObjectUnsubscribedErrorImpl(this: Error) {`
`10`	`10`	`Error.call(this);`
`11`	`11`	`this.message = 'object unsubscribed';`
`12`	`12`	`this.name = 'ObjectUnsubscribedError';`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ export interface TimeoutErrorCtor {`
`6`	`6`	`}`
`7`	`7`
`8`	`8`	`const TimeoutErrorImpl = (() => {`
`9`		`- function TimeoutErrorImpl(this: any) {`
	`9`	`+ function TimeoutErrorImpl(this: Error) {`
`10`	`10`	`Error.call(this);`
`11`	`11`	`this.message = 'Timeout has occurred';`
`12`	`12`	`this.name = 'TimeoutError';`