Fix crash on exit when closing browser immediately (cztomczak#454)

cztomczak · cztomczak · commit 66107b258657 · 2018-08-17T18:02:05.000+02:00
diff --git a/src/browser.pyx b/src/browser.pyx
@@ -334,6 +334,17 @@ cdef class PyBrowser:
         # will be called.
         Debug("CefBrowser::CloseBrowser(%s)" % forceClose)
 
+        # Fix Issue #454 "Crash on exit when closing browser
+        #                 immediately during initial loading".
+        if not self.cefBrowser.get():
+            Debug("cefBrowser.get() failed in CloseBrowser")
+            return
+        # From testing it seems that only cefBrowser.get() can fail,
+        # however let's check the host as well just to be safe.
+        if not self.cefBrowser.get().GetHost().get():
+            Debug("cefBrowser.get().GetHost() failed in CloseBrowser")
+            return
+
         # Flush cookies to disk. Temporary solution for Issue #365.
         # A similar call is made in LifespanHandler_OnBeforeClose.
         # If using GetCookieManager to implement custom cookie managers
