Fix contract violation on code that never executes

ibauersachs · ibauersachs · commit c96667ecba39 · 2021-02-01T23:31:59.000+01:00
diff --git a/src/main/java/org/xbill/DNS/SVCBBase.java b/src/main/java/org/xbill/DNS/SVCBBase.java
@@ -564,7 +564,8 @@ public String toString() {
           InetAddress addr = InetAddress.getByAddress(null, b);
           sb.append(addr.getHostAddress());
         } catch (UnknownHostException e) {
-          return null;
+          // should not happen, but returning null and throwing is bad
+          return e.getMessage();
         }
       }
       return sb.toString();

Original file line number	Diff line number	Diff line change
`@@ -564,7 +564,8 @@ public String toString() {`
`564`	`564`	`InetAddress addr = InetAddress.getByAddress(null, b);`
`565`	`565`	`sb.append(addr.getHostAddress());`
`566`	`566`	`} catch (UnknownHostException e) {`
`567`		`- return null;`
	`567`	`+ // should not happen, but returning null and throwing is bad`
	`568`	`+ return e.getMessage();`
`568`	`569`	`}`
`569`	`570`	`}`
`570`	`571`	`return sb.toString();`