BAEL-3603 Update method names and variable name for PR

rojyates · rojyates · commit 944ac49aa25b · 2020-03-16T06:24:59.000+10:00
diff --git a/core-java-modules/core-java-io-2/src/test/java/com/baeldung/blockingnonblocking/BlockingClientUnitTest.java b/core-java-modules/core-java-io-2/src/test/java/com/baeldung/blockingnonblocking/BlockingClientUnitTest.java
@@ -25,7 +25,7 @@ public void setup() {
     }
 
     @Test
-    public void givenJavaIOSocket_whenReadingAndWritingWithStreams_thenReadSuccessfully() throws IOException {
+    public void givenJavaIOSocket_whenReadingAndWritingWithStreams_thenSuccess() throws IOException {
         // given an IO socket and somewhere to store our result
         Socket socket = new Socket("localhost", wireMockRule.port());
         StringBuilder ourStore = new StringBuilder();
diff --git a/core-java-modules/core-java-io-2/src/test/java/com/baeldung/blockingnonblocking/NonBlockingClientUnitTest.java b/core-java-modules/core-java-io-2/src/test/java/com/baeldung/blockingnonblocking/NonBlockingClientUnitTest.java
@@ -31,7 +31,7 @@ public void setup() {
     }
 
     @Test
-    public void givenJavaNIOSocketChannel_whenReadingAndWriting_thenUseBuffers() throws IOException {
+    public void givenJavaNIOSocketChannel_whenReadingAndWritingWithBuffers_thenSuccess() throws IOException {
         // given a NIO SocketChannel and a charset
         InetSocketAddress address = new InetSocketAddress("localhost", wireMockRule.port());
         SocketChannel socketChannel = SocketChannel.open(address);
@@ -58,25 +58,25 @@ public void givenJavaNIOSocketChannel_whenReadingAndWriting_thenUseBuffers() thr
     }
 
     @Test
-    public void givenJavaNIO_whenReadingAndWriting_thenSmallBuffers() throws IOException {
+    public void givenJavaNIOSocketChannel_whenReadingAndWritingWithSmallBuffers_thenSuccess() throws IOException {
         // given a NIO SocketChannel and a charset
         InetSocketAddress address = new InetSocketAddress("localhost", wireMockRule.port());
-        SocketChannel socket = SocketChannel.open(address);
+        SocketChannel socketChannel = SocketChannel.open(address);
         Charset charset = StandardCharsets.UTF_8;
 
         // when we write and read using buffers that are too small for our message
-        socket.write(charset.encode(CharBuffer.wrap("GET " + REQUESTED_RESOURCE + " HTTP/1.0\r\n\r\n")));
+        socketChannel.write(charset.encode(CharBuffer.wrap("GET " + REQUESTED_RESOURCE + " HTTP/1.0\r\n\r\n")));
 
         ByteBuffer buffer = ByteBuffer.allocate(8); // or allocateDirect if we need direct memory access
         CharBuffer charBuffer = CharBuffer.allocate(8);
         CharsetDecoder decoder = charset.newDecoder();
         StringBuilder ourStore = new StringBuilder();
-        while (socket.read(buffer) != -1 || buffer.position() > 0) {
+        while (socketChannel.read(buffer) != -1 || buffer.position() > 0) {
             buffer.flip();
             storeBufferContents(buffer, charBuffer, decoder, ourStore);
             buffer.compact();
         }
-        socket.close();
+        socketChannel.close();
 
         // then we read and saved our data
         assertTrue(ourStore

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ public void setup() {`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`@Test`
`28`		`- public void givenJavaIOSocket_whenReadingAndWritingWithStreams_thenReadSuccessfully() throws IOException {`
	`28`	`+ public void givenJavaIOSocket_whenReadingAndWritingWithStreams_thenSuccess() throws IOException {`
`29`	`29`	`// given an IO socket and somewhere to store our result`
`30`	`30`	`Socket socket = new Socket("localhost", wireMockRule.port());`
`31`	`31`	`StringBuilder ourStore = new StringBuilder();`