-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathbinding_bind_test.go
More file actions
584 lines (494 loc) · 14.2 KB
/
binding_bind_test.go
File metadata and controls
584 lines (494 loc) · 14.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
package rigging
import (
"reflect"
"testing"
"time"
)
func TestBindStruct_SimpleFields(t *testing.T) {
type Config struct {
Host string
Port int
}
data := map[string]mergedEntry{
"host": {value: "localhost", sourceName: "env"},
"port": {value: "8080", sourceName: "env"},
}
var cfg Config
var provFields []FieldProvenance
errors := bindStruct(reflect.ValueOf(&cfg), data, &provFields, "", "")
if len(errors) > 0 {
t.Fatalf("unexpected errors: %v", errors)
}
if cfg.Host != "localhost" {
t.Errorf("Host = %q, want %q", cfg.Host, "localhost")
}
if cfg.Port != 8080 {
t.Errorf("Port = %d, want %d", cfg.Port, 8080)
}
// Check provenance
if len(provFields) != 2 {
t.Fatalf("provenance fields = %d, want 2", len(provFields))
}
}
func TestBindStruct_WithDefaults(t *testing.T) {
type Config struct {
Host string `conf:"default:localhost"`
Port int `conf:"default:8080"`
}
data := map[string]mergedEntry{
"host": {value: "example.com", sourceName: "env"},
// port not provided, should use default
}
var cfg Config
var provFields []FieldProvenance
errors := bindStruct(reflect.ValueOf(&cfg), data, &provFields, "", "")
if len(errors) > 0 {
t.Fatalf("unexpected errors: %v", errors)
}
if cfg.Host != "example.com" {
t.Errorf("Host = %q, want %q", cfg.Host, "example.com")
}
if cfg.Port != 8080 {
t.Errorf("Port = %d, want %d", cfg.Port, 8080)
}
// Check that default source is recorded
portProv := findProvenance(provFields, "Port")
if portProv == nil {
t.Fatal("Port provenance not found")
}
if portProv.SourceName != "default" {
t.Errorf("Port source = %q, want %q", portProv.SourceName, "default")
}
}
func TestBindStruct_RequiredField(t *testing.T) {
type Config struct {
Host string `conf:"required"`
Port int
}
data := map[string]mergedEntry{
"port": {value: "8080", sourceName: "env"},
// host not provided but required
}
var cfg Config
var provFields []FieldProvenance
errors := bindStruct(reflect.ValueOf(&cfg), data, &provFields, "", "")
// Binding phase should not check for required fields - that's validation's job
// So we expect 0 errors from binding
if len(errors) != 0 {
t.Fatalf("errors = %d, want 0 (required check is done in validation phase)", len(errors))
}
// Verify that Port was set correctly
if cfg.Port != 8080 {
t.Errorf("Port = %d, want 8080", cfg.Port)
}
// Verify that Host is zero value (empty string)
if cfg.Host != "" {
t.Errorf("Host = %q, want empty string", cfg.Host)
}
}
func TestBindStruct_TypeConversionError(t *testing.T) {
type Config struct {
Port int
}
data := map[string]mergedEntry{
"port": {value: "not-a-number", sourceName: "env"},
}
var cfg Config
var provFields []FieldProvenance
errors := bindStruct(reflect.ValueOf(&cfg), data, &provFields, "", "")
if len(errors) != 1 {
t.Fatalf("errors = %d, want 1", len(errors))
}
if errors[0].Code != ErrCodeInvalidType {
t.Errorf("error code = %q, want %q", errors[0].Code, ErrCodeInvalidType)
}
if errors[0].FieldPath != "Port" {
t.Errorf("error field path = %q, want %q", errors[0].FieldPath, "Port")
}
}
func TestBindStruct_NestedStruct(t *testing.T) {
type Database struct {
Host string
Port int
}
type Config struct {
Database Database
}
data := map[string]mergedEntry{
"database.host": {value: "db.example.com", sourceName: "file"},
"database.port": {value: "5432", sourceName: "file"},
}
var cfg Config
var provFields []FieldProvenance
errors := bindStruct(reflect.ValueOf(&cfg), data, &provFields, "", "")
if len(errors) > 0 {
t.Fatalf("unexpected errors: %v", errors)
}
if cfg.Database.Host != "db.example.com" {
t.Errorf("Database.Host = %q, want %q", cfg.Database.Host, "db.example.com")
}
if cfg.Database.Port != 5432 {
t.Errorf("Database.Port = %d, want %d", cfg.Database.Port, 5432)
}
// Check provenance includes nested field paths
hostProv := findProvenance(provFields, "Database.Host")
if hostProv == nil {
t.Fatal("Database.Host provenance not found")
}
if hostProv.KeyPath != "database.host" {
t.Errorf("Database.Host key path = %q, want %q", hostProv.KeyPath, "database.host")
}
}
func TestBindStruct_NestedStructWithPrefix(t *testing.T) {
type Database struct {
Host string
Port int
}
type Config struct {
Database Database `conf:"prefix:db"`
}
data := map[string]mergedEntry{
"db.host": {value: "db.example.com", sourceName: "env"},
"db.port": {value: "5432", sourceName: "env"},
}
var cfg Config
var provFields []FieldProvenance
errors := bindStruct(reflect.ValueOf(&cfg), data, &provFields, "", "")
if len(errors) > 0 {
t.Fatalf("unexpected errors: %v", errors)
}
if cfg.Database.Host != "db.example.com" {
t.Errorf("Database.Host = %q, want %q", cfg.Database.Host, "db.example.com")
}
if cfg.Database.Port != 5432 {
t.Errorf("Database.Port = %d, want %d", cfg.Database.Port, 5432)
}
// Check provenance uses prefix
hostProv := findProvenance(provFields, "Database.Host")
if hostProv == nil {
t.Fatal("Database.Host provenance not found")
}
if hostProv.KeyPath != "db.host" {
t.Errorf("Database.Host key path = %q, want %q", hostProv.KeyPath, "db.host")
}
}
func TestBindStruct_CustomName(t *testing.T) {
type Config struct {
APIKey string `conf:"name:api.key"`
}
data := map[string]mergedEntry{
"api.key": {value: "secret123", sourceName: "env"},
}
var cfg Config
var provFields []FieldProvenance
errors := bindStruct(reflect.ValueOf(&cfg), data, &provFields, "", "")
if len(errors) > 0 {
t.Fatalf("unexpected errors: %v", errors)
}
if cfg.APIKey != "secret123" {
t.Errorf("APIKey = %q, want %q", cfg.APIKey, "secret123")
}
// Check provenance uses custom name
apiProv := findProvenance(provFields, "APIKey")
if apiProv == nil {
t.Fatal("APIKey provenance not found")
}
if apiProv.KeyPath != "api.key" {
t.Errorf("APIKey key path = %q, want %q", apiProv.KeyPath, "api.key")
}
}
func TestBindStruct_EnvTag(t *testing.T) {
type Config struct {
DBHost string `conf:"env:DB__HOST"`
}
data := map[string]mergedEntry{
"db.host": {value: "db.example.com", sourceName: "env"},
}
var cfg Config
var provFields []FieldProvenance
errors := bindStruct(reflect.ValueOf(&cfg), data, &provFields, "", "")
if len(errors) > 0 {
t.Fatalf("unexpected errors: %v", errors)
}
if cfg.DBHost != "db.example.com" {
t.Errorf("DBHost = %q, want %q", cfg.DBHost, "db.example.com")
}
hostProv := findProvenance(provFields, "DBHost")
if hostProv == nil {
t.Fatal("DBHost provenance not found")
}
if hostProv.KeyPath != "db.host" {
t.Errorf("DBHost key path = %q, want %q", hostProv.KeyPath, "db.host")
}
}
func TestBindStruct_SecretField(t *testing.T) {
type Config struct {
Password string `conf:"secret"`
}
data := map[string]mergedEntry{
"password": {value: "secret123", sourceName: "env"},
}
var cfg Config
var provFields []FieldProvenance
errors := bindStruct(reflect.ValueOf(&cfg), data, &provFields, "", "")
if len(errors) > 0 {
t.Fatalf("unexpected errors: %v", errors)
}
if cfg.Password != "secret123" {
t.Errorf("Password = %q, want %q", cfg.Password, "secret123")
}
// Check provenance marks field as secret
passProv := findProvenance(provFields, "Password")
if passProv == nil {
t.Fatal("Password provenance not found")
}
if !passProv.Secret {
t.Error("Password should be marked as secret")
}
}
func TestBindStruct_OptionalField(t *testing.T) {
type Config struct {
Timeout Optional[time.Duration]
}
t.Run("value provided", func(t *testing.T) {
data := map[string]mergedEntry{
"timeout": {value: "5s", sourceName: "env"},
}
var cfg Config
var provFields []FieldProvenance
errors := bindStruct(reflect.ValueOf(&cfg), data, &provFields, "", "")
if len(errors) > 0 {
t.Fatalf("unexpected errors: %v", errors)
}
val, set := cfg.Timeout.Get()
if !set {
t.Error("Timeout should be set")
}
if val != 5*time.Second {
t.Errorf("Timeout = %v, want %v", val, 5*time.Second)
}
})
t.Run("value not provided", func(t *testing.T) {
data := map[string]mergedEntry{}
var cfg Config
var provFields []FieldProvenance
errors := bindStruct(reflect.ValueOf(&cfg), data, &provFields, "", "")
if len(errors) > 0 {
t.Fatalf("unexpected errors: %v", errors)
}
_, set := cfg.Timeout.Get()
if set {
t.Error("Timeout should not be set")
}
})
t.Run("default value", func(t *testing.T) {
type ConfigWithDefault struct {
Timeout Optional[time.Duration] `conf:"default:10s"`
}
data := map[string]mergedEntry{}
var cfg ConfigWithDefault
var provFields []FieldProvenance
errors := bindStruct(reflect.ValueOf(&cfg), data, &provFields, "", "")
if len(errors) > 0 {
t.Fatalf("unexpected errors: %v", errors)
}
val, set := cfg.Timeout.Get()
if !set {
t.Error("Timeout should be set from default")
}
if val != 10*time.Second {
t.Errorf("Timeout = %v, want %v", val, 10*time.Second)
}
})
}
func TestBindStruct_ValueSetLookalikeStructIsNotOptional(t *testing.T) {
type ValueSet struct {
Value int
Set bool
}
type Config struct {
Flag ValueSet
}
data := map[string]mergedEntry{
"flag.value": {value: "42", sourceName: "env"},
"flag.set": {value: "true", sourceName: "env"},
}
var cfg Config
var provFields []FieldProvenance
errors := bindStruct(reflect.ValueOf(&cfg), data, &provFields, "", "")
if len(errors) > 0 {
t.Fatalf("unexpected errors: %v", errors)
}
if cfg.Flag.Value != 42 {
t.Errorf("Flag.Value = %d, want %d", cfg.Flag.Value, 42)
}
if !cfg.Flag.Set {
t.Errorf("Flag.Set = %v, want true", cfg.Flag.Set)
}
valueProv := findProvenance(provFields, "Flag.Value")
if valueProv == nil {
t.Fatal("Flag.Value provenance not found")
}
setProv := findProvenance(provFields, "Flag.Set")
if setProv == nil {
t.Fatal("Flag.Set provenance not found")
}
}
func TestBindStruct_MultipleErrors(t *testing.T) {
type Config struct {
Host string `conf:"required"`
Port int `conf:"required"`
Max int
}
data := map[string]mergedEntry{
"max": {value: "not-a-number", sourceName: "env"},
// host and port missing
}
var cfg Config
var provFields []FieldProvenance
errors := bindStruct(reflect.ValueOf(&cfg), data, &provFields, "", "")
// Binding phase only checks type conversion errors, not required fields
// Should have 1 error: 1 type conversion (required checks are in validation phase)
if len(errors) != 1 {
t.Fatalf("errors = %d, want 1 (only type conversion error)", len(errors))
}
// Check we have the type conversion error
if errors[0].Code != ErrCodeInvalidType {
t.Errorf("error code = %q, want %q", errors[0].Code, ErrCodeInvalidType)
}
if errors[0].FieldPath != "Max" {
t.Errorf("error field path = %q, want %q", errors[0].FieldPath, "Max")
}
}
func TestBindStruct_AllTypes(t *testing.T) {
type Config struct {
Str string
Bool bool
Int int
Int8 int8
Int16 int16
Int32 int32
Int64 int64
Uint uint
Uint8 uint8
Uint16 uint16
Uint32 uint32
Uint64 uint64
Float32 float32
Float64 float64
Duration time.Duration
Strings []string
}
data := map[string]mergedEntry{
"str": {value: "hello", sourceName: "env"},
"bool": {value: "true", sourceName: "env"},
"int": {value: "42", sourceName: "env"},
"int8": {value: "8", sourceName: "env"},
"int16": {value: "16", sourceName: "env"},
"int32": {value: "32", sourceName: "env"},
"int64": {value: "64", sourceName: "env"},
"uint": {value: "42", sourceName: "env"},
"uint8": {value: "8", sourceName: "env"},
"uint16": {value: "16", sourceName: "env"},
"uint32": {value: "32", sourceName: "env"},
"uint64": {value: "64", sourceName: "env"},
"float32": {value: "3.14", sourceName: "env"},
"float64": {value: "2.718", sourceName: "env"},
"duration": {value: "5m", sourceName: "env"},
"strings": {value: "a,b,c", sourceName: "env"},
}
var cfg Config
var provFields []FieldProvenance
errors := bindStruct(reflect.ValueOf(&cfg), data, &provFields, "", "")
if len(errors) > 0 {
t.Fatalf("unexpected errors: %v", errors)
}
if cfg.Str != "hello" {
t.Errorf("Str = %q, want %q", cfg.Str, "hello")
}
if cfg.Bool != true {
t.Errorf("Bool = %v, want %v", cfg.Bool, true)
}
if cfg.Int != 42 {
t.Errorf("Int = %d, want %d", cfg.Int, 42)
}
if cfg.Int8 != 8 {
t.Errorf("Int8 = %d, want %d", cfg.Int8, 8)
}
if cfg.Int16 != 16 {
t.Errorf("Int16 = %d, want %d", cfg.Int16, 16)
}
if cfg.Int32 != 32 {
t.Errorf("Int32 = %d, want %d", cfg.Int32, 32)
}
if cfg.Int64 != 64 {
t.Errorf("Int64 = %d, want %d", cfg.Int64, 64)
}
if cfg.Uint != 42 {
t.Errorf("Uint = %d, want %d", cfg.Uint, 42)
}
if cfg.Uint8 != 8 {
t.Errorf("Uint8 = %d, want %d", cfg.Uint8, 8)
}
if cfg.Uint16 != 16 {
t.Errorf("Uint16 = %d, want %d", cfg.Uint16, 16)
}
if cfg.Uint32 != 32 {
t.Errorf("Uint32 = %d, want %d", cfg.Uint32, 32)
}
if cfg.Uint64 != 64 {
t.Errorf("Uint64 = %d, want %d", cfg.Uint64, 64)
}
if cfg.Float32 != 3.14 {
t.Errorf("Float32 = %f, want %f", cfg.Float32, 3.14)
}
if cfg.Float64 != 2.718 {
t.Errorf("Float64 = %f, want %f", cfg.Float64, 2.718)
}
if cfg.Duration != 5*time.Minute {
t.Errorf("Duration = %v, want %v", cfg.Duration, 5*time.Minute)
}
if !reflect.DeepEqual(cfg.Strings, []string{"a", "b", "c"}) {
t.Errorf("Strings = %v, want %v", cfg.Strings, []string{"a", "b", "c"})
}
}
func TestBindStruct_NestedStructFromMap(t *testing.T) {
type Database struct {
Host string
Port int
}
type Config struct {
Database Database
}
// Simulate file source that provides nested map
data := map[string]mergedEntry{
"database": {
value: map[string]any{
"host": "db.example.com",
"port": 5432,
},
sourceName: "file",
},
}
var cfg Config
var provFields []FieldProvenance
errors := bindStruct(reflect.ValueOf(&cfg), data, &provFields, "", "")
if len(errors) > 0 {
t.Fatalf("unexpected errors: %v", errors)
}
if cfg.Database.Host != "db.example.com" {
t.Errorf("Database.Host = %q, want %q", cfg.Database.Host, "db.example.com")
}
if cfg.Database.Port != 5432 {
t.Errorf("Database.Port = %d, want %d", cfg.Database.Port, 5432)
}
}
// Helper function to find provenance by field path
func findProvenance(fields []FieldProvenance, fieldPath string) *FieldProvenance {
for i := range fields {
if fields[i].FieldPath == fieldPath {
return &fields[i]
}
}
return nil
}