Improved error message for id_token verification errors

hjmikkon · hjmikkon · commit 9d859c7a3034 · 2018-11-08T15:52:48.000+02:00
diff --git a/src/main/java/org/oidc/msg/oidc/AccessTokenResponse.java b/src/main/java/org/oidc/msg/oidc/AccessTokenResponse.java
@@ -215,7 +215,8 @@ protected void doVerify() {
         if (!idToken.verify()) {
           for (ErrorDetails idTokenErrorDetails : idToken.getError().getDetails()) {
             ErrorDetails details = new ErrorDetails("id_token", idTokenErrorDetails.getErrorType(),
-                idTokenErrorDetails.getErrorMessage(), idTokenErrorDetails.getErrorCause());
+                "Cause: (" + idTokenErrorDetails.toString() + ")", 
+                idTokenErrorDetails.getErrorCause());
             getError().getDetails().add(details);
           }
         }
diff --git a/src/main/java/org/oidc/msg/oidc/AuthenticationResponse.java b/src/main/java/org/oidc/msg/oidc/AuthenticationResponse.java
@@ -218,7 +218,8 @@ protected void doVerify() {
         if (!idToken.verify()) {
           for (ErrorDetails idTokenErrorDetails : idToken.getError().getDetails()) {
             ErrorDetails details = new ErrorDetails("id_token", idTokenErrorDetails.getErrorType(),
-                idTokenErrorDetails.getErrorMessage(), idTokenErrorDetails.getErrorCause());
+                "Cause: (" + idTokenErrorDetails.toString() + ")", 
+                idTokenErrorDetails.getErrorCause());
             getError().getDetails().add(details);
           }
         }

Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,8 @@ protected void doVerify() {`
`215`	`215`	`if (!idToken.verify()) {`
`216`	`216`	`for (ErrorDetails idTokenErrorDetails : idToken.getError().getDetails()) {`
`217`	`217`	`ErrorDetails details = new ErrorDetails("id_token", idTokenErrorDetails.getErrorType(),`
`218`		`- idTokenErrorDetails.getErrorMessage(), idTokenErrorDetails.getErrorCause());`
	`218`	`+ "Cause: (" + idTokenErrorDetails.toString() + ")",`
	`219`	`+ idTokenErrorDetails.getErrorCause());`
`219`	`220`	`getError().getDetails().add(details);`
`220`	`221`	`}`
`221`	`222`	`}`
Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,8 @@ protected void doVerify() {`
`218`	`218`	`if (!idToken.verify()) {`
`219`	`219`	`for (ErrorDetails idTokenErrorDetails : idToken.getError().getDetails()) {`
`220`	`220`	`ErrorDetails details = new ErrorDetails("id_token", idTokenErrorDetails.getErrorType(),`
`221`		`- idTokenErrorDetails.getErrorMessage(), idTokenErrorDetails.getErrorCause());`
	`221`	`+ "Cause: (" + idTokenErrorDetails.toString() + ")",`
	`222`	`+ idTokenErrorDetails.getErrorCause());`
`222`	`223`	`getError().getDetails().add(details);`
`223`	`224`	`}`
`224`	`225`	`}`