Skip to content

Commit d397873

Browse files
committed
tests updated to work with updated getJWTVerifyKeys handling issuer correctly
1 parent a6a58ac commit d397873

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/test/java/org/oidc/msg/AbstractMessageTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ public void testSuccessFromJWTSignVerifyNone() throws InvalidClaimException, Ill
194194
String jwt = getSignedJwt("none");
195195
KeyJar keyJar = getKeyJarPub();
196196
mockMessage.fromJwt(jwt, keyJar, keyOwner);
197-
Assert.assertEquals(mockMessage.getClaims().get("iss"), "op");
197+
Assert.assertEquals(mockMessage.getClaims().get("iss"), keyOwner);
198198
}
199199

200200
@Test
@@ -209,7 +209,7 @@ public void testSuccessFromJWTSignVerifyRS() throws InvalidClaimException, Illeg
209209
mockMessage.fromJwt(jwt, keyJar, keyOwner);
210210
jwt = getSignedJwt("RS512");
211211
mockMessage.fromJwt(jwt, keyJar, keyOwner);
212-
Assert.assertEquals(mockMessage.getClaims().get("iss"), "op");
212+
Assert.assertEquals(mockMessage.getClaims().get("iss"), keyOwner);
213213
}
214214

215215
@Test

src/test/java/org/oidc/msg/BaseMessageTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public abstract class BaseMessageTest<T extends AbstractMessage> {
5050
private static final String PRIVATE_KEY_FILE = "src/test/resources/rsa-private.pem";
5151
private static final String PUBLIC_KEY_FILE = "src/test/resources/rsa-public.pem";
5252
//TODO: return keyOwner to https://issuer.example.com once edmund explains how parameter is used in getJWTVerifyKeys
53-
protected String keyOwner = "";//"https://issuer.example.com";
53+
protected String keyOwner = "https://issuer.example.com";
5454
protected KeyJar keyJarOfPrivateKeys = null;
5555
protected KeyJar keyJarOfPublicKeys = null;
5656
protected String signedJwt = null;
@@ -148,7 +148,7 @@ protected String getSignedJwt(String alg)
148148
default:
149149
break;
150150
}
151-
return JWT.create().withIssuer("op").sign(algorithm);
151+
return JWT.create().withIssuer(keyOwner).sign(algorithm);
152152
}
153153

154154
/**
@@ -209,7 +209,7 @@ protected KeyJar getKeyJarPub()
209209
*/
210210
protected String generateIdTokenNow(Map<String, Object> claims, Key key, String algo)
211211
throws InvalidClaimException {
212-
claims.put("iss", "issuer");
212+
claims.put("iss", keyOwner);
213213
claims.put("sub", "subject");
214214
claims.put("aud", "clientid");
215215
claims.put("exp", (System.currentTimeMillis() / 1000) + 5);

src/test/java/org/oidc/msg/oidc/AuthenticationRequestTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ public void testUrlEncodingSuccess()
248248

249249
private IDToken getIDTokenHint() throws InvalidClaimException {
250250
Map<String, Object> idTokenClaims = new HashMap<String, Object>();
251-
idTokenClaims.put("iss", "issuer");
251+
idTokenClaims.put("iss", keyOwner);
252252
idTokenClaims.put("sub", "subject");
253253
idTokenClaims.put("aud", "clientid");
254254
long now = System.currentTimeMillis() / 1000;

0 commit comments

Comments
 (0)