Merge pull request kubernetes-client#2316 from anvil-works/handle-ws-close

k8s-ci-robot · web-flow · commit e93f24075993 · 2025-01-17T16:06:35.000-08:00
Close the Python sockets when the Websocket closes
diff --git a/kubernetes/base/stream/ws_client.py b/kubernetes/base/stream/ws_client.py
@@ -30,7 +30,7 @@
 from six.moves.urllib.parse import urlencode, urlparse, urlunparse
 from six import StringIO, BytesIO
 
-from websocket import WebSocket, ABNF, enableTrace
+from websocket import WebSocket, ABNF, enableTrace, WebSocketConnectionClosedException
 from base64 import urlsafe_b64decode
 from requests.utils import should_bypass_proxies
 
@@ -379,7 +379,12 @@ def _proxy(self):
                 if sock == self.websocket:
                     pending = True
                     while pending:
-                        opcode, frame = self.websocket.recv_data_frame(True)
+                        try:
+                            opcode, frame = self.websocket.recv_data_frame(True)
+                        except WebSocketConnectionClosedException:
+                            for port in self.local_ports.values():
+                                port.python.close()
+                            return
                         if opcode == ABNF.OPCODE_BINARY:
                             if not frame.data:
                                 raise RuntimeError("Unexpected frame data size")
