Skip to content

Commit 8973181

Browse files
author
adriancole
committed
update example to use feign 2.0.0 syntax
1 parent 9a24c59 commit 8973181

2 files changed

Lines changed: 12 additions & 11 deletions

File tree

examples/feign-example-cli/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
apply plugin: 'java'
22

33
dependencies {
4-
compile 'com.netflix.feign:feign-core:1.1.1'
4+
compile 'com.netflix.feign:feign-core:2.0.0'
55
compile 'com.google.code.gson:gson:2.2.4'
66
provided 'com.squareup.dagger:dagger-compiler:1.0.1'
77
}

examples/feign-example-cli/src/main/java/feign/example/cli/GitHubExample.java

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,21 @@
1515
*/
1616
package feign.example.cli;
1717

18-
import com.google.common.collect.ImmutableMap;
19-
import com.google.common.reflect.TypeToken;
2018
import com.google.gson.Gson;
2119

2220
import java.io.Reader;
21+
import java.lang.reflect.Type;
22+
import java.util.LinkedHashMap;
2323
import java.util.List;
2424
import java.util.Map;
2525

26+
import javax.inject.Named;
2627
import javax.inject.Singleton;
27-
import javax.ws.rs.GET;
28-
import javax.ws.rs.Path;
29-
import javax.ws.rs.PathParam;
3028

3129
import dagger.Module;
3230
import dagger.Provides;
3331
import feign.Feign;
32+
import feign.RequestLine;
3433
import feign.codec.Decoder;
3534

3635
/**
@@ -39,8 +38,8 @@
3938
public class GitHubExample {
4039

4140
interface GitHub {
42-
@GET @Path("/repos/{owner}/{repo}/contributors")
43-
List<Contributor> contributors(@PathParam("owner") String owner, @PathParam("repo") String repo);
41+
@RequestLine("GET /repos/{owner}/{repo}/contributors")
42+
List<Contributor> contributors(@Named("owner") String owner, @Named("repo") String repo);
4443
}
4544

4645
static class Contributor {
@@ -64,14 +63,16 @@ public static void main(String... args) {
6463
@Module(overrides = true, library = true)
6564
static class GsonModule {
6665
@Provides @Singleton Map<String, Decoder> decoders() {
67-
return ImmutableMap.of("GitHub", jsonDecoder);
66+
Map<String, Decoder> decoders = new LinkedHashMap<String, Decoder>();
67+
decoders.put("GitHub", jsonDecoder);
68+
return decoders;
6869
}
6970

7071
final Decoder jsonDecoder = new Decoder() {
7172
Gson gson = new Gson();
7273

73-
@Override public Object decode(String methodKey, Reader reader, TypeToken<?> type) {
74-
return gson.fromJson(reader, type.getType());
74+
@Override public Object decode(String methodKey, Reader reader, Type type) {
75+
return gson.fromJson(reader, type);
7576
}
7677
};
7778
}

0 commit comments

Comments
 (0)