Show point counts in dataset mismatch warning

ThomasKroes · ThomasKroes · commit 08f3fe689158 · 2026-02-25T10:06:41.000+01:00
Cache the number of points for the scalar source and position datasets and use those values in the mismatch notification. This avoids repeated getNumPoints() calls and provides a clearer notification message (includes numPositions and numScalars) when the two datasets have different sizes.
diff --git a/src/ScalarAction.cpp b/src/ScalarAction.cpp
@@ -24,11 +24,13 @@ ScalarAction::ScalarAction(QObject* parent, const QString& title, const float& m
             if (auto scatterplotPlugin = dynamic_cast<ScatterplotPlugin*>(findPluginAncestor())) {
                 auto positionDataset            = scatterplotPlugin->getPositionDataset();
                 auto scalarSourcePointsDataset  = Dataset<Points>(getCurrentDataset());
+                const auto numScalars           = scalarSourcePointsDataset->getNumPoints();
+                const auto numPositions         = positionDataset->getNumPoints();
 
-                if (scalarSourcePointsDataset->getNumPoints() != positionDataset->getNumPoints()) {
+                if (numScalars != numPositions) {
                     emitSourceSelectionChanged = false;
 
-                    scatterplotPlugin->addNotification("The number of points in the scalar source dataset does not match the number of points in the position dataset.");
+                    scatterplotPlugin->addNotification(QString("The number of points in the scalar source dataset does not match the number of points in the position dataset. (numPositions=%1, numScalars:%2)").arg(QString::number(numPositions), QString::number(numScalars)));
                 }
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -24,11 +24,13 @@ ScalarAction::ScalarAction(QObject* parent, const QString& title, const float& m`
`24`	`24`	`if (auto scatterplotPlugin = dynamic_cast<ScatterplotPlugin*>(findPluginAncestor())) {`
`25`	`25`	`auto positionDataset = scatterplotPlugin->getPositionDataset();`
`26`	`26`	`auto scalarSourcePointsDataset = Dataset<Points>(getCurrentDataset());`
	`27`	`+ const auto numScalars = scalarSourcePointsDataset->getNumPoints();`
	`28`	`+ const auto numPositions = positionDataset->getNumPoints();`
`27`	`29`
`28`		`- if (scalarSourcePointsDataset->getNumPoints() != positionDataset->getNumPoints()) {`
	`30`	`+ if (numScalars != numPositions) {`
`29`	`31`	`emitSourceSelectionChanged = false;`
`30`	`32`
`31`		`- scatterplotPlugin->addNotification("The number of points in the scalar source dataset does not match the number of points in the position dataset.");`
	`33`	`+ scatterplotPlugin->addNotification(QString("The number of points in the scalar source dataset does not match the number of points in the position dataset. (numPositions=%1, numScalars:%2)").arg(QString::number(numPositions), QString::number(numScalars)));`
`32`	`34`	`}`
`33`	`35`	`}`
`34`	`36`	`}`