Merge pull request zedr#26 from peter-gribanov/default_arguments

Tomáš Votruba · web-flow · commit 3d5a1b0fe846 · 2017-09-05T14:10:38.000+02:00
[Bugfix] Use default arguments in PHP 7+
diff --git a/README.md b/README.md
@@ -186,22 +186,40 @@ class Car
 
 ### Use default arguments instead of short circuiting or conditionals
 
-**Bad:**
+**Not good:**
+
+This is not good because `$breweryName` can be `NULL`.
+
 ```php
-function createMicrobrewery($name = null) {
-    $breweryName = $name ?: 'Hipster Brew Co.';
-    // ...
+function createMicrobrewery($breweryName = 'Hipster Brew Co.')
+{
+    // ...
 }
-
 ```
 
-**Good**:
+**Not bad:**
+
+This opinion is more understandable than the previous version, but it better controls the value of the variable.
+
 ```php
-function createMicrobrewery($breweryName = 'Hipster Brew Co.') {
+function createMicrobrewery($name = null)
+{
+    $breweryName = $name ?: 'Hipster Brew Co.';
     // ...
 }
+```
+
+**Good**:
+
+If you support only PHP 7+, then you can use [type hinting](http://php.net/manual/en/functions.arguments.php#functions.arguments.type-declaration) and be sure that the `$breweryName` will not be `NULL`.
 
+```php
+function createMicrobrewery(string $breweryName = 'Hipster Brew Co.')
+{
+    // ...
+}
 ```
+
 **[⬆ back to top](#table-of-contents)**
 ## **Functions**
 ### Function arguments (2 or fewer ideally)
