feat!: drop support of keep_connection parameter

IATkachenko · IATkachenko · commit e21d489f87ca · 2022-07-08T23:23:21.000+03:00
BREAKING CHANGES: get and get_state_from_breezer have no keep_connection parameter now. Use connect/disconnect instead
diff --git a/tion_btle/tion.py b/tion_btle/tion.py
@@ -171,39 +171,33 @@ def heating(self) -> str:
         return "off"
 
     @final
-    async def get_state_from_breezer(self, keep_connection: bool = False) -> None:
+    async def get_state_from_breezer(self) -> None:
         """
         Get current state from breezer
-        :param keep_connection: should we keep connection to device or disconnect after getting data
         :return: None
         """
         try:
             await self.connect()
             await self._try_write(request=self.command_getStatus)
             response = await self._get_data_from_breezer()
         finally:
-            if not keep_connection:
-                await self.disconnect()
-            else:
-                _LOGGER.warning("You are using keep_connection parameter of get method. It will be removed in v2.0.0")
-                self.__connections_count -= 1
+            await self.disconnect()
 
         self._decode_response(response)
 
     @final
-    async def get(self, keep_connection: bool = False, skip_update: bool = False) -> dict:
+    async def get(self, skip_update: bool = False) -> dict:
         """
         Report current breezer state
         :param skip_update: may we skip requesting data from breezer or not
-        :param keep_connection: should we keep connection to device or disconnect after getting data
         :return:
           dictionary with device state
         """
         if skip_update and self.have_breezer_state:
             _LOGGER.debug(f"Skipping getting state from breezer because skip_update={skip_update} and "
                           f"have_breezer_state={self.have_breezer_state}")
         else:
-            await self.get_state_from_breezer(keep_connection)
+            await self.get_state_from_breezer()
         common = self.__generate_common_json()
         model_specific_data = self._generate_model_specific_json()
 
