tion: decode temperature from device with additional code

IATkachenko · IATkachenko · commit feda4dbffd55 · 2020-03-17T16:27:57.000+03:00
Tion use additional code for coding returned temperature and we should process it correctly. Fixes #1
diff --git a/s3.py b/s3.py
@@ -88,8 +88,8 @@ def _decode_response(self, response: bytearray) -> dict:
         "mode": self._process_mode(int(list("{:02x}".format(response[2]))[0])),
         "fan_speed": int(list("{:02x}".format(response[2]))[1]),
         "heater_temp": response[3],
-        "in_temp": response[8],
-        "out_temp": response[7],
+        "in_temp": self.decode_temperature(response[8]),
+        "out_temp": self.decode_temperature(response[7]),
         "filter_remain": response[10]*256 + response[9],
         "time": "{}:{}".format(response[11],response[12]),
         "request_error_code": response[13],
diff --git a/tests/decode_temperature.py b/tests/decode_temperature.py
@@ -0,0 +1,19 @@
+#!/usr/bin/python
+import sys
+import os
+import unittest
+
+PACKAGE_PARENT = '..'
+SCRIPT_DIR = os.path.dirname(os.path.realpath(os.path.join(os.getcwd(), os.path.expanduser(__file__))))
+sys.path.append(os.path.normpath(os.path.join(SCRIPT_DIR, PACKAGE_PARENT)))
+
+import tion
+
+class TestDecodeTemperature(unittest.TestCase, tion.tion):
+  def test_positive(self):
+    self.assertEqual(self.decode_temperature(0x09), 9, "Should be 9")
+  def test_negative(self):
+    self.assertEqual(self.decode_temperature(0xFF), -1, "Should be -1")
+
+if __name__ == '__main__':
+  unittest.main()
diff --git a/tion.py b/tion.py
@@ -41,3 +41,18 @@ def get() -> dict:
       dictionay with device paramters
     """
     pass
+
+  def decode_temperature(self, raw: bytes) -> int:
+    """ Converts temperature from bytes with addition code to int
+    Args:
+      raw: raw temperature value from Tion
+    Returns:
+      Integer value for temperature
+    """
+    barrier = 0b10000000
+    if (raw < barrier):
+      result = raw
+    else:
+      result = -(~(result - barrier) + barrier + 1)
+
+    return result
