only print deprecated appdynamics warnings when appdynamics is used

Tilly Taylor · dwillist · Tilly Taylor · commit 7d93c9f3dd5b · 2019-05-15T15:55:32.000-04:00
[#164703749]

Co-authored-by: Daniel Thornton &lt;dthornton@pivotal.io&gt;
diff --git a/src/python/hooks/appdynamics.go b/src/python/hooks/appdynamics.go
@@ -149,9 +149,7 @@ func (h AppdynamicsHook) BeforeCompile(stager *libbuildpack.Stager) error {
 		return nil
 	}
 
-	h.Log.Warning("[DEPRECATION WARNING]:")
-	h.Log.Warning("Please use AppDynamics extension buildpack for Python Application instrumentation")
-	h.Log.Warning("for more details: https://docs.pivotal.io/partners/appdynamics/multibuildpack.html")
+	// Some env var or something that lets us know that we are using app dynamics?
 
 	vcapServices := os.Getenv("VCAP_SERVICES")
 	services := make(map[string][]Plan)
@@ -168,6 +166,9 @@ func (h AppdynamicsHook) BeforeCompile(stager *libbuildpack.Stager) error {
 			return nil
 		} else if match {
 			appdServiceName = serviceName
+			h.Log.Warning("[DEPRECATION WARNING]:")
+			h.Log.Warning("Please use AppDynamics extension buildpack for Python Application instrumentation")
+			h.Log.Warning("for more details: https://docs.pivotal.io/partners/appdynamics/multibuildpack.html")
 			break
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -149,9 +149,7 @@ func (h AppdynamicsHook) BeforeCompile(stager *libbuildpack.Stager) error {`
`149`	`149`	`return nil`
`150`	`150`	`}`
`151`	`151`
`152`		`- h.Log.Warning("[DEPRECATION WARNING]:")`
`153`		`- h.Log.Warning("Please use AppDynamics extension buildpack for Python Application instrumentation")`
`154`		`- h.Log.Warning("for more details: https://docs.pivotal.io/partners/appdynamics/multibuildpack.html")`
	`152`	`+ // Some env var or something that lets us know that we are using app dynamics?`
`155`	`153`
`156`	`154`	`vcapServices := os.Getenv("VCAP_SERVICES")`
`157`	`155`	`services := make(map[string][]Plan)`
`@@ -168,6 +166,9 @@ func (h AppdynamicsHook) BeforeCompile(stager *libbuildpack.Stager) error {`
`168`	`166`	`return nil`
`169`	`167`	`} else if match {`
`170`	`168`	`appdServiceName = serviceName`
	`169`	`+ h.Log.Warning("[DEPRECATION WARNING]:")`
	`170`	`+ h.Log.Warning("Please use AppDynamics extension buildpack for Python Application instrumentation")`
	`171`	`+ h.Log.Warning("for more details: https://docs.pivotal.io/partners/appdynamics/multibuildpack.html")`
`171`	`172`	`break`
`172`	`173`	`}`
`173`	`174`	`}`