Skip to content

Commit 8647e29

Browse files
brayanhenaorobdimsdale
authored andcommitted
Resolve pr requested changes
1 parent f803e63 commit 8647e29

2 files changed

Lines changed: 16 additions & 16 deletions

File tree

src/python/integration/init_test.go

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package integration_test
22

33
import (
44
"flag"
5+
"github.com/onsi/gomega/types"
56
"os"
67
"path/filepath"
78
"testing"
@@ -120,3 +121,17 @@ func TestIntegration(t *testing.T) {
120121
Expect(platform.Delete.Execute(dynatraceName)).To(Succeed())
121122
Expect(os.Remove(os.Getenv("BUILDPACK_FILE"))).To(Succeed())
122123
}
124+
125+
func CreateRequirementsTxtFile(Expect func(actual interface{}, extra ...interface{}) types.Assertion, path string, fileName string, modules ...string) {
126+
file, err := os.Create(filepath.Join(path, fileName))
127+
Expect(err).NotTo(HaveOccurred())
128+
129+
for _, module := range modules {
130+
_, err = file.WriteString(module + "\n")
131+
Expect(err).NotTo(HaveOccurred())
132+
}
133+
134+
err = file.Close()
135+
136+
Expect(err).NotTo(HaveOccurred())
137+
}

src/python/integration/pip_test.go

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package integration_test
22

33
import (
4-
"github.com/onsi/gomega/types"
54
"os"
65
"path/filepath"
76
"testing"
@@ -54,7 +53,7 @@ func testPip(platform switchblade.Platform, fixtures string) func(*testing.T, sp
5453
Expect(os.RemoveAll(source)).To(Succeed())
5554
})
5655

57-
it("installs the regulations-core package", func() {
56+
it("handles recursive requirements successfully", func() {
5857
deployment, logs, err := platform.Deploy.
5958
Execute(name, source)
6059
Expect(err).NotTo(HaveOccurred())
@@ -210,17 +209,3 @@ func testPip(platform switchblade.Platform, fixtures string) func(*testing.T, sp
210209
})
211210
}
212211
}
213-
214-
func CreateRequirementsTxtFile(Expect func(actual interface{}, extra ...interface{}) types.Assertion, path string, fileName string, modules ...string) {
215-
file, err := os.Create(filepath.Join(path, fileName))
216-
Expect(err).NotTo(HaveOccurred())
217-
218-
for _, module := range modules {
219-
_, err = file.WriteString(module + "\n")
220-
Expect(err).NotTo(HaveOccurred())
221-
}
222-
223-
err = file.Close()
224-
225-
Expect(err).NotTo(HaveOccurred())
226-
}

0 commit comments

Comments
 (0)