added tests for endless_pages

martinotten · martinotten · commit 6ed6f13e483e · 2013-06-13T17:00:40.000+02:00
diff --git a/lib/adcloud/endless_pages.rb b/lib/adcloud/endless_pages.rb
@@ -1,65 +1,68 @@
-module EndlessPages
-  extend ActiveSupport::Concern
+module Adcloud
+  module EndlessPages
+    extend ActiveSupport::Concern
 
-  module ClassMethods
+    module ClassMethods
 
-    def endless_pages(opts = {}, &block)
-      @opts = opts
-      perform(&block)
-    end
+      def endless_pages(opts = {}, &block)
+        @opts = opts
+        perform(&block)
+      end
 
-    def conn
-      @opts[:connection] ||= Adcloud::Connection.new
-    end
+      def conn
+        @opts[:connection] ||= Adcloud::Connection.new
+      end
 
-    def endpoint
-      @opts[:endpoint_url] ||= self.endpoint_url
-      raise "You must either pass endpoint_url into endless_pages OR define a class method .endpoint_url" unless @opts[:endpoint_url]
-      @opts[:endpoint_url]
-    end
+      def endpoint
+        @opts[:endpoint_url] ||= self.endpoint_url
+        raise "You must either pass endpoint_url into endless_pages OR define a class method .endpoint_url" unless @opts[:endpoint_url]
+        @opts[:endpoint_url]
+      end
 
-    def params
-        @opts[:params] ||= {}
-    end
+      def params
+          @opts[:params] ||= {}
+      end
 
-    def perform(&block)
-      paged_items = []
+      def perform(&block)
+        paged_items = []
 
-      page = params[:page] ||= 1
-      page = 1 if page == 0
+        page = params[:page] ||= 1
+        page = 1 if page == 0
 
-      total_pages = 1
-      retry_count = 0
-      page_result = params[:page_result] ||= []
+        total_pages = 1
+        retry_count = 0
+        page_result = params[:page_result] ||= []
 
-      begin
-        Adcloud::logger.debug "Page: #{page}"
+        begin
+          Adcloud::logger.debug "Page: #{page}"
 
-        params[:page] = page
+          params[:page] = page
 
-        raw_result = conn.get(endpoint, params)
-        total_pages = raw_result['_meta']['total_pages']
-        Adcloud::logger.debug "total_pages: #{total_pages}"
-        page_result = self.new(raw_result) # your service class needs to include Virtus
-        # if a block is provided then start returning results right away
-        page_result.items.each do |item|
-          block.call(item)
-        end if block
+          raw_result = conn.get(endpoint, params)
+          total_pages = raw_result['_meta']['total_pages'] || 0
+          Adcloud::logger.debug "total_pages: #{total_pages}"
+          page_result = self.new(raw_result) # your service class needs to include Virtus
+          # if a block is provided then start returning results right away
+          page_result.items.each do |item|
+            block.call(item)
+          end if block
 
-        paged_items += page_result.items
-        page += 1
-      rescue => ex
-        if retry_count <= 5
-          retry
-        else
-          Adcloud.logger.error { "API Exception #{ex}" }
-          raise ApiError, "Connection failed"
-        end
-        retry_count += 1
-      end while page <= total_pages
-      Adcloud::logger.debug "Items: #{paged_items.length}"
-      paged_items
-    end
+          paged_items += page_result.items
+          page += 1
+        rescue => ex
+          Adcloud.logger.debug "Retry count: #{retry_count}"
+          if retry_count == 5
+            retry_count += 1
+            retry
+          else
+            Adcloud.logger.error { "API Exception #{ex}" }
+            raise StandardError, "Connection failed"
+          end
+        end while page <= total_pages
+        Adcloud::logger.debug "Items: #{paged_items.length}"
+        paged_items
+      end
 
+    end
   end
-end
+end
diff --git a/test/adcloud/endless_pages_test.rb b/test/adcloud/endless_pages_test.rb
@@ -0,0 +1,43 @@
+require 'test_helper'
+
+class DummyConnection
+  def get(endpoint, params)
+    {'_meta' => {'total_pages' => 3}, 'items' => [params[:page]]}
+  end
+end
+
+class Foo
+  include Adcloud::EndlessPages
+  include Virtus
+  attribute :_meta, Hash
+  attribute :items, Array
+
+  def self.endpoint_url
+    ""
+  end
+end
+
+describe Adcloud::EndlessPages do
+  subject { 
+    Foo
+  }
+  it "raises an ApiError after 5 retries" do
+    stub_request(:post, "https://api.adcloud.com/v2/oauth/access_token").
+      with(:body => {"client_id"=>true, "client_secret"=>true, "grant_type"=>"none"},
+           :headers => {'Accept'=>'*/*', 'Content-Type'=>'application/x-www-form-urlencoded', 'User-Agent'=>'Faraday v0.8.7'}).
+      to_return(:status => 200, :body => "", :headers => {})
+    proc {
+      subject.endless_pages({})
+    }.must_raise StandardError
+  end
+
+  it "iterates through all pages" do
+    result = subject.endless_pages({endpoint_url: "http://www.example.com", connection: DummyConnection.new})
+    result.must_equal [1,2,3]
+  end
+
+  it "gathers all results and returns a single collection" do
+    result = subject.endless_pages({endpoint_url: "http://www.example.com", connection: DummyConnection.new})
+    result.must_equal [1,2,3]
+  end
+end
