pagination skipped the last page

martinotten · martinotten · commit ba7b2c147fcb · 2013-06-12T15:44:59.000+02:00
diff --git a/.ruby-version b/.ruby-version
@@ -0,0 +1 @@
+1.9.3-p392
diff --git a/lib/adcloud/endless_pages.rb b/lib/adcloud/endless_pages.rb
@@ -33,9 +33,11 @@ def perform(&block)
       page_result = params[:page_result] ||= []
 
       begin
+        Adcloud::logger.debug "Page: #{page}"
+
         raw_result = conn.get(endpoint, params)
         total_pages = raw_result['_meta']['total_pages']
-
+        Adcloud::logger.debug "total_pages: #{total_pages}"
         page_result = self.new(raw_result) # your service class needs to include Virtus
         # if a block is provided then start returning results right away
         page_result.items.each do |item|
@@ -44,7 +46,6 @@ def perform(&block)
 
         paged_items += page_result.items
         page += 1
-
       rescue => ex
         if retry_count <= 5
           retry
@@ -53,8 +54,8 @@ def perform(&block)
           raise ApiError, "Connection failed"
         end
         retry_count += 1
-      end while page < total_pages
-
+      end while page <= total_pages
+      Adcloud::logger.debug "Items: #{paged_items.length}"
       paged_items
     end
 
