fix: check all job states in dedup guard for fake and memory adapters

OhSo-Dublin · OhSo-Dublin · commit 422a3606cbb5 · 2026-04-10T23:09:41.000+05:30
diff --git a/README.md b/README.md
@@ -152,10 +152,11 @@ await SendInvoiceJob.dispatch({ orderId: 123 }).id('order-123').run()
 await SendReceiptJob.dispatch({ orderId: 123 }).id('order-123').run()
 ```
 
-Deduplication is atomic and race-condition-free across all adapters:
+Deduplication is atomic and race-condition-free for adapters that support storage-level uniqueness checks:
 
 - **Redis**: Uses `HSETNX` (set-if-not-exists)
 - **Knex**: Uses `INSERT ... ON CONFLICT DO NOTHING`
+- **SyncAdapter**: Executes jobs inline and does not support deduplication
 
 > [!NOTE]
 > Without `.id()`, jobs use auto-generated UUIDs and are never deduplicated. The `.id()` method is only available on single dispatch, not `dispatchMany`.
diff --git a/src/drivers/fake_adapter.ts b/src/drivers/fake_adapter.ts
@@ -161,8 +161,8 @@ export class FakeAdapter implements Adapter {
 
   async pushOn(queue: string, jobData: JobData): Promise<void> {
     if (jobData.unique) {
-      const jobs = this.#queues.get(queue)
-      if (jobs?.some((j) => j.id === jobData.id)) return
+      const existing = await this.getJob(jobData.id, queue)
+      if (existing) return
     }
 
     this.#recordPush(queue, jobData)
@@ -173,13 +173,10 @@ export class FakeAdapter implements Adapter {
     return this.pushLaterOn('default', jobData, delay)
   }
 
-  pushLaterOn(queue: string, jobData: JobData, delay: number): Promise<void> {
+  async pushLaterOn(queue: string, jobData: JobData, delay: number): Promise<void> {
     if (jobData.unique) {
-      const jobs = this.#queues.get(queue)
-      if (jobs?.some((j) => j.id === jobData.id)) return Promise.resolve()
-
-      const delayed = this.#delayedJobs.get(queue)
-      if (delayed?.has(jobData.id)) return Promise.resolve()
+      const existing = await this.getJob(jobData.id, queue)
+      if (existing) return
     }
 
     this.#recordPush(queue, jobData, delay)
diff --git a/tests/_mocks/memory_adapter.ts b/tests/_mocks/memory_adapter.ts
@@ -52,8 +52,8 @@ export class MemoryAdapter implements Adapter {
 
   async pushOn(queue: string, jobData: JobData): Promise<void> {
     if (jobData.unique) {
-      const jobs = this.#queues.get(queue)
-      if (jobs?.some((j) => j.id === jobData.id)) return
+      const existing = await this.getJob(jobData.id, queue)
+      if (existing) return
     }
 
     if (!this.#queues.has(queue)) {
@@ -67,13 +67,10 @@ export class MemoryAdapter implements Adapter {
     return this.pushLaterOn('default', jobData, delay)
   }
 
-  pushLaterOn(queue: string, jobData: JobData, delay: number): Promise<void> {
+  async pushLaterOn(queue: string, jobData: JobData, delay: number): Promise<void> {
     if (jobData.unique) {
-      const jobs = this.#queues.get(queue)
-      if (jobs?.some((j) => j.id === jobData.id)) return Promise.resolve()
-
-      const delayed = this.#delayedJobs.get(queue)
-      if (delayed?.has(jobData.id)) return Promise.resolve()
+      const existing = await this.getJob(jobData.id, queue)
+      if (existing) return
     }
 
     if (!this.#delayedJobs.has(queue)) {
