Skip to content

Commit 886e8e0

Browse files
committed
Fix conditional dependency on libs required for SNI
And replace them with requests[security] Signed-off-by: Sebastian Ramacher <[email protected]>
1 parent f4087c2 commit 886e8e0

2 files changed

Lines changed: 6 additions & 11 deletions

File tree

README.rst

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,10 @@ Dependencies
1818
* watchdog (optional, for monitoring imported modules for changes)
1919
* jedi (optional, for experimental multiline completion)
2020

21-
If you are using Python 2 on Mac OS X, the following dependencies are required
22-
as well:
21+
If you are using Python 2 before 2.7.7, the following dependency is also
22+
required:
2323

24-
* pyOpenSSL
25-
* ndg-httpsclien
26-
* pyasn1
24+
* requests[security]
2725

2826
If you have problems installing cffi which is needed by pyOpenSSL,
2927
please take a look at https://cffi.readthedocs.org/en/release-0.8/#macos-x.

setup.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -219,12 +219,9 @@ def initialize_options(self):
219219
'urwid': ['urwid'],
220220
'watch': ['watchdog'],
221221
'jedi': ['jedi'],
222-
# need PyOpenSSL for SNI support (only 2.X and on Darwin)
223-
# list of packages taken from
224-
# https://github.com/kennethreitz/requests/blob/master/requests/packages/urllib3/contrib/pyopenssl.py
225-
':sys_platform == "darwin" and '\
226-
'(python_version == "2.6" or python_version == "2.7")': [
227-
'PyOpenSSL', 'ndg-httpsclient', 'pyasn1'
222+
# need requests[security] for SNI support (only before 2.7.7)
223+
':python_full_version <= "2.7.7"': [
224+
'requests[security]'
228225
]
229226
}
230227

0 commit comments

Comments
 (0)