Skip to content

Commit c331a3c

Browse files
committed
chore: minor fixes
1 parent dbc5865 commit c331a3c

4 files changed

Lines changed: 7 additions & 4 deletions

File tree

.github/workflows/tests.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -283,8 +283,6 @@ jobs:
283283
name: E2E Service Test (Dev Keys)
284284
runs-on: ubuntu-latest
285285
needs: setup
286-
strategy:
287-
fail-fast: false
288286
steps:
289287
- name: checkout
290288
uses: actions/checkout@v4

src/Appwrite/Network/Platform.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,9 @@ public static function getHostnames(array $platforms): array
6969
switch ($type) {
7070
case self::TYPE_WEB:
7171
case self::TYPE_FLUTTER_WEB:
72-
$hostnames[] = $hostname;
72+
if (!empty($hostname)) {
73+
$hostnames[] = $hostname;
74+
}
7375
break;
7476
case self::TYPE_FLUTTER_IOS:
7577
case self::TYPE_FLUTTER_ANDROID:
@@ -83,6 +85,7 @@ public static function getHostnames(array $platforms): array
8385
case self::TYPE_APPLE_TVOS:
8486
case self::TYPE_REACT_NATIVE_IOS:
8587
case self::TYPE_REACT_NATIVE_ANDROID:
88+
case self::TYPE_UNITY:
8689
if (!empty($key)) {
8790
$hostnames[] = $key;
8891
}

src/Appwrite/Network/Validator/Origin.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class Origin extends Validator
1616
/**
1717
* Constructor
1818
*
19-
* @param array<Document> $platforms
19+
* @param array<\Utopia\Database\Document> $platforms
2020
*/
2121
public function __construct(array $platforms)
2222
{

tests/e2e/Scopes/Scope.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,8 @@ public function getUser(): array
189189
'name' => $name,
190190
]);
191191

192+
fwrite(STDERR, json_encode($user, JSON_PRETTY_PRINT));
193+
192194
$this->assertEquals(201, $user['headers']['status-code']);
193195

194196
$session = $this->client->call(Client::METHOD_POST, '/account/sessions/email', [

0 commit comments

Comments
 (0)