Remove duplicate FollowRedirects function (mrtazz#109)

drodil · mrtazz · commit 1d6f6c6d3a20 · 2018-10-31T13:37:43.000+01:00
Use default value for maxRedirects instead
diff --git a/include/restclient-cpp/connection.h b/include/restclient-cpp/connection.h
@@ -138,11 +138,9 @@ class Connection {
     // set to not use signals
     void SetNoSignal(bool no);
 
-    // set whether to follow redirects
-    void FollowRedirects(bool follow);
-
-    // set whether to follow redirects (-1 for unlimited)
-    void FollowRedirects(bool follow, int maxRedirects);
+    // set whether to follow redirects, maxRedirects indicitng the maximum
+    // number of redirects to follow
+    void FollowRedirects(bool follow, int maxRedirects = -1l);
 
     // set custom user agent
     // (this will result in the UA "foo/cool restclient-cpp/VERSION")
diff --git a/source/connection.cc b/source/connection.cc
@@ -118,18 +118,7 @@ RestClient::Connection::GetHeaders() {
  * @brief configure whether to follow redirects on this connection
  *
  * @param follow - boolean whether to follow redirects
- */
-void
-RestClient::Connection::FollowRedirects(bool follow) {
-  this->followRedirects = follow;
-  this->maxRedirects = -1l;
-}
-
-/**
- * @brief configure whether to follow redirects on this connection
- *
- * @param follow - boolean whether to follow redirects
- * @param maxRedirects - int indicating the maximum number of redirect to follow (-1 unlimited)
+ * @param maxRedirects - int indicating the maximum number of redirect to follow (-1 unlimited, default)
  */
 void
 RestClient::Connection::FollowRedirects(bool follow, int maxRedirects) {
