Small optimizations

mgerhardy · mrtazz · commit ac7cef2a6728 · 2016-11-28T09:36:55.000-05:00
use std::move in c++11 mode pass by reference to prevent string copy use char in find_first_of (no length evaluation needed) closes mrtazz#65
diff --git a/include/restclient-cpp/connection.h b/include/restclient-cpp/connection.h
@@ -104,7 +104,7 @@ class Connection {
     } Info;
 
 
-    explicit Connection(const std::string baseUrl);
+    explicit Connection(const std::string& baseUrl);
     ~Connection();
 
     // Instance configuration methods
diff --git a/source/connection.cc b/source/connection.cc
@@ -13,6 +13,7 @@
 #include <iostream>
 #include <map>
 #include <stdexcept>
+#include <utility>
 
 #include "restclient-cpp/restclient.h"
 #include "restclient-cpp/helpers.h"
@@ -24,7 +25,7 @@
  * @param baseUrl - base URL for the connection to use
  *
  */
-RestClient::Connection::Connection(const std::string baseUrl)
+RestClient::Connection::Connection(const std::string& baseUrl)
                                : lastRequest(), headerFields() {
   this->curlHandle = curl_easy_init();
   if (!this->curlHandle) {
@@ -84,7 +85,11 @@ RestClient::Connection::AppendHeader(const std::string& key,
  */
 void
 RestClient::Connection::SetHeaders(RestClient::HeaderFields headers) {
+#if __cplusplus >= 201103L
+  this->headerFields = std::move(headers);
+#else
   this->headerFields = headers;
+#endif
 }
 
 /**
diff --git a/source/helpers.cc b/source/helpers.cc
@@ -43,7 +43,7 @@ size_t RestClient::Helpers::header_callback(void *data, size_t size,
   RestClient::Response* r;
   r = reinterpret_cast<RestClient::Response*>(userdata);
   std::string header(reinterpret_cast<char*>(data), size*nmemb);
-  size_t seperator = header.find_first_of(":");
+  size_t seperator = header.find_first_of(':');
   if ( std::string::npos == seperator ) {
     // roll with non seperated headers...
     trim(header);
