Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: github/secure_headers
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: github/secure_headers
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: rei-moo/csp-nonce-conflict
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 14 files changed
  • 10 contributors

Commits on Dec 16, 2025

  1. fix(cookies): fix compatibility with rack 3

    Do not join cookies with new like if they weren't before
    
    fix(middleware): ensure headers are wrapped with `Rack::Headers`
    
    Add `Rack::Headers` wrapping to middleware to
    prevent header manipulation issues. Added a test
    to verify cookies remain as an array when flagged
    if already in array format.
    deril authored and rei-moo committed Dec 16, 2025
    Configuration menu
    Copy the full SHA
    d133044 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2025

  1. Remove non-lowercase headers in Rails default configuration (fixes #541)

    While this gem now uses lowercase headers, the Rails default configuration still
    defines non-lowercase headers.  As a result, our Railtie will not remove those
    conflicting headers.
    
    This change ensures that we're accounting for both lowercase and non-lowercase
    default headers in Rails.
    obrie authored and rei-moo committed Dec 17, 2025
    Configuration menu
    Copy the full SHA
    9bc0b6c View commit details
    Browse the repository at this point in the history
  2. normalize domains with trailing slashes

    CSP3 more explicitly calls this out:
    
    > If path A consists of one character that is equal to the U+002F
    > SOLIDUS character (/) and path B is empty, return "Matches".
    
    A URL like `example.com/foo` will match a connect-src of `example.com`,
    as well as `example.com/`, so having two connect-srcs listed like this
    is redundant.
    
    fix: allow URIs with schema to have trailing slashes normalised
    
    Co-authored-by: Dusty Greif <[email protected]>
    2 people authored and rei-moo committed Dec 17, 2025
    Configuration menu
    Copy the full SHA
    3334929 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7f19fb2 View commit details
    Browse the repository at this point in the history
  4. Refactor rake task methods into module for better testing

    Fix rake task file count output message
    rahearn authored and rei-moo committed Dec 17, 2025
    Configuration menu
    Copy the full SHA
    b3557f7 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2025

  1. Don't set upgrade_insecure_requests for HTTP requests (fixes #348)

    Co-authored-by: fletchto99 <[email protected]>m>
    2 people authored and fletchto99 committed Dec 19, 2025
    Configuration menu
    Copy the full SHA
    d774c23 View commit details
    Browse the repository at this point in the history
  2. Add Configuration.disable! option (fixes #540)

    Co-authored-by: fletchto99 <[email protected]>
    Copilot and fletchto99 committed Dec 19, 2025
    Configuration menu
    Copy the full SHA
    e5f347e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2801582 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5051880 View commit details
    Browse the repository at this point in the history
Loading