#1782: don't leak in error case in PyModule_AddXxxConstant. Patch by Hrvoje Nikšić.

georg.brandl · georg.brandl · commit fde27e0573f5 · 2008-01-19T18:02:46.000Z
git-svn-id: http://svn.python.org/projects/python/trunk@60084 6015fed2-1504-0410-9fe1-9d1591cc4771
diff --git a/Python/modsupport.c b/Python/modsupport.c
@@ -621,11 +621,23 @@ PyModule_AddObject(PyObject *m, const char *name, PyObject *o)
 int 
 PyModule_AddIntConstant(PyObject *m, const char *name, long value)
 {
-	return PyModule_AddObject(m, name, PyInt_FromLong(value));
+	PyObject *o = PyInt_FromLong(value);
+	if (!o)
+		return -1;
+	if (PyModule_AddObject(m, name, o) == 0)
+		return 0;
+	Py_DECREF(o);
+	return -1;
 }
 
 int 
 PyModule_AddStringConstant(PyObject *m, const char *name, const char *value)
 {
-	return PyModule_AddObject(m, name, PyString_FromString(value));
+	PyObject *o = PyString_FromString(value);
+	if (!o)
+		return -1;
+	if (PyModule_AddObject(m, name, o) == 0)
+		return 0;
+	Py_DECREF(o);
+	return -1;
 }
