Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

fix(4.0.x): sessions were not always removed from checkedOutSessions#1448

Merged
thiagotnunes merged 3 commits into4.0.xfrom
remove-from-checked-out-4.0.x
Sep 29, 2021
Merged

fix(4.0.x): sessions were not always removed from checkedOutSessions#1448
thiagotnunes merged 3 commits into4.0.xfrom
remove-from-checked-out-4.0.x

Conversation

@olavloite
Copy link
Copy Markdown
Collaborator

Sessions were added to a set of checked out sessions when one was checked out from
the session pool. When the session was released back to the pool, the session would
normally be removed from the set of checked out sessions. The latter would not always
happen if the application that checked out the session did not use the session for
any reads or writes.

Sessions were added to a set of checked out sessions when one was checked out from
the session pool. When the session was released back to the pool, the session would
normally be removed from the set of checked out sessions. The latter would not always
happen if the application that checked out the session did not use the session for
any reads or writes.

chore: fix maven version to 3.8.1

chore: fix maven version for windows
@olavloite olavloite requested review from a team September 24, 2021 08:42
@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml

@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/java-spanner API. label Sep 24, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2021
@thiagotnunes thiagotnunes changed the title fix: sessions were not always removed from checkedOutSessions fix(4.0.x): sessions were not always removed from checkedOutSessions Sep 24, 2021
@thiagotnunes thiagotnunes added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 29, 2021

Codecov Report

❗ No coverage uploaded for pull request base (4.0.x@207d7f8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             4.0.x    #1448   +/-   ##
========================================
  Coverage         ?   85.24%           
  Complexity       ?     2624           
========================================
  Files            ?      145           
  Lines            ?    14292           
  Branches         ?     1380           
========================================
  Hits             ?    12183           
  Misses           ?     1532           
  Partials         ?      577           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 207d7f8...36bcf22. Read the comment docs.

@thiagotnunes thiagotnunes added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 29, 2021
@thiagotnunes thiagotnunes merged commit c48f22c into 4.0.x Sep 29, 2021
@thiagotnunes thiagotnunes deleted the remove-from-checked-out-4.0.x branch September 29, 2021 04:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants