Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

deps(3.3.x): update OpenCensus API to 0.30.0#1610

Merged
thiagotnunes merged 2 commits into3.3.xfrom
opencensus-0.30-3.3.x
Dec 17, 2021
Merged

deps(3.3.x): update OpenCensus API to 0.30.0#1610
thiagotnunes merged 2 commits into3.3.xfrom
opencensus-0.30-3.3.x

Conversation

@thiagotnunes
Copy link
Copy Markdown
Contributor

@thiagotnunes thiagotnunes commented Dec 17, 2021

No description provided.

@thiagotnunes
deps: update OpenCensus API to 0.30.0
6c1107e
@thiagotnunes
test: fix instance admin test
7945209 
The list instance filter was matching several instances, because they
contained the same prefix. We now perform an exact match instead.
@thiagotnunes thiagotnunes requested review from a team December 17, 2021 10:38
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/java-spanner API. label Dec 17, 2021
@thiagotnunes
Copy link
Copy Markdown
Contributor Author

thiagotnunes commented Dec 17, 2021

Fixes #1606

olavloite
olavloite reviewed Dec 17, 2021
View reviewed changes
Comment thread google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITInstanceAdminTest.java
.listInstances(
Options.filter(
"name:instances/" + env.getTestHelper().getInstanceId().getInstance()))
.listInstances(Options.filter("name=" + env.getTestHelper().getInstanceId()))
Copy link
Copy Markdown
Collaborator

@olavloite olavloite Dec 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be "name:" + env.getTestHelper().getInstanceId()

See https://cloud.google.com/spanner/docs/reference/rpc/google.spanner.admin.instance.v1#google.spanner.admin.instance.v1.ListInstancesRequest

Copy link
Copy Markdown
Contributor Author

@thiagotnunes thiagotnunes Dec 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem here is that : operator is a contains and we have 3 instances that start with spanner-testing. That is why the test is failing.

By using the = operator we do an exact match instead, having a single instance returned. More on operators here: https://cloud.google.com/sdk/gcloud/reference/topic/filters

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 17, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (3.3.x@4bced4f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             3.3.x    #1610   +/-   ##
========================================
  Coverage         ?   85.12%           
  Complexity       ?     2568           
========================================
  Files            ?      143           
  Lines            ?    14069           
  Branches         ?     1351           
========================================
  Hits             ?    11976           
  Misses           ?     1531           
  Partials         ?      562

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bced4f...7945209. Read the comment docs.

@thiagotnunes thiagotnunes merged commit 3b4b8c6 into 3.3.x Dec 17, 2021
@thiagotnunes thiagotnunes deleted the opencensus-0.30-3.3.x branch December 17, 2021 13:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@olavloite olavloite olavloite left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thiagotnunes @olavloite