This repository was archived by the owner on Apr 7, 2026. It is now read-only.
fix(3.1.x): blanks span for session keepAlive traces#855
Merged
thiagotnunes merged 1 commit intogoogleapis:3.1.xfrom Feb 9, 2021
Merged
Conversation
The keepAlive traces were being tracked along with the parent span set by the client, which clutters the tracing stack. Here, we set the tracing to blank before issueing the keepAlive query.
Codecov Report
@@ Coverage Diff @@
## 3.1.x #855 +/- ##
============================================
- Coverage 85.05% 85.05% -0.01%
+ Complexity 2556 2554 -2
============================================
Files 142 142
Lines 13930 13934 +4
Branches 1326 1326
============================================
+ Hits 11848 11851 +3
+ Misses 1526 1525 -1
- Partials 556 558 +2
Continue to review full report at Codecov.
|
olavloite
approved these changes
Feb 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keepAlive traces were being tracked along with the parent span set by the client, which clutters the tracing stack. Here, we set the tracing to blank before issuing the keepAlive query.