Make JWTDecodeException extend JWTVerificationException

lbalmaceda · lbalmaceda · commit ae65a6d71e60 · 2016-11-14T16:20:54.000-03:00
diff --git a/README.md b/README.md
@@ -93,8 +93,6 @@ try {
         .withIssuer("auth0")
         .build(); //Reusable verifier instance
     JWT jwt = verifier.verify(token);
-} catch (JWTDecodeException exception){
-    //Invalid token
 } catch (JWTVerificationException exception){
     //Invalid signature/claims
 }
@@ -110,14 +108,11 @@ try {
         .withIssuer("auth0")
         .build(); //Reusable verifier instance
     JWT jwt = verifier.verify(token);
-} catch (JWTDecodeException exception){
-    //Invalid token
 } catch (JWTVerificationException exception){
     //Invalid signature/claims
 }
 ```
 
-If the token has an invalid syntax or the header or payload are not JSONs, a `JWTDecodeException` will raise.
 If the token has an invalid signature or the Claim requirement is not met, a `JWTVerificationException` will raise.
 
 
diff --git a/lib/src/main/java/com/auth0/jwt/JWTVerifier.java b/lib/src/main/java/com/auth0/jwt/JWTVerifier.java
@@ -162,7 +162,7 @@ public Verification withJWTId(String jwtId) {
         /**
          * Require a specific Claim value.
          *
-         * @param name the Claim's name
+         * @param name  the Claim's name
          * @param value the Claim's value. Must be an instance of Integer, Double, Boolean, Date or String class.
          * @return this same Verification instance.
          * @throws IllegalArgumentException if the name is null or the value class is not allowed.
@@ -229,10 +229,9 @@ private void requireClaim(String name, Object value) {
      *
      * @param token the String representation of the JWT.
      * @return a verified JWT.
-     * @throws JWTDecodeException       if any part of the Token contained an invalid JWT or JSON format.
      * @throws JWTVerificationException if any of the required contents inside the JWT is invalid.
      */
-    public JWT verify(String token) throws JWTDecodeException, JWTVerificationException {
+    public JWT verify(String token) throws JWTVerificationException {
         JWT jwt = new JWT(JWTDecoder.decode(token));
         verifyAlgorithm(jwt, algorithm);
         verifySignature(TokenUtils.splitToken(token));
diff --git a/lib/src/main/java/com/auth0/jwt/exceptions/JWTDecodeException.java b/lib/src/main/java/com/auth0/jwt/exceptions/JWTDecodeException.java
@@ -1,6 +1,6 @@
 package com.auth0.jwt.exceptions;
 
-public class JWTDecodeException extends RuntimeException {
+public class JWTDecodeException extends JWTVerificationException {
     public JWTDecodeException(String message) {
         this(message, null);
     }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`package com.auth0.jwt.exceptions;`
`2`	`2`
`3`		`-public class JWTDecodeException extends RuntimeException {`
	`3`	`+public class JWTDecodeException extends JWTVerificationException {`
`4`	`4`	`public JWTDecodeException(String message) {`
`5`	`5`	`this(message, null);`
`6`	`6`	`}`