When names of method parameters same as class members, 'self.' with be prepend to references of method parameters. The patch fix this bug.

liling · liling · commit 2f081db926ea · 2007-10-05T10:46:10.000Z
diff --git a/java2python/lib/sourcetypes.py b/java2python/lib/sourcetypes.py
@@ -889,6 +889,7 @@ def addParameter(self, typ, name):
         name = self.alternateName(name)
         typ = Source.alternateName(self, typ, 'typeTypeMap')
         self.parameters.append((typ, name))
+        self.variables.append(Variable(self, name))
 
     def formatDecl(self, indent):
         """ generates a class statement accounting for base types
diff --git a/java2python/tests/ClassMember.java b/java2python/tests/ClassMember.java
@@ -9,6 +9,10 @@ public void add() {
         c++;
         a++;
     }
+
+    public void setA(int a) {
+        this.a = a;
+    }
 }
 
 public class ClassMember extends TestCase {
@@ -27,4 +31,10 @@ public void testStaticMember() {
         Assert.assertEquals(Simple.c, 2);
         Assert.assertEquals(x.c, 2);
     }
+
+    public void testParamName() {
+        Simple x = new Simple();
+        x.setA(10);
+        Assert.assertEquals(x.a, 10);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,10 @@ public void add() {`
`9`	`9`	`c++;`
`10`	`10`	`a++;`
`11`	`11`	`}`
	`12`	`+`
	`13`	`+ public void setA(int a) {`
	`14`	`+ this.a = a;`
	`15`	`+ }`
`12`	`16`	`}`
`13`	`17`
`14`	`18`	`public class ClassMember extends TestCase {`
`@@ -27,4 +31,10 @@ public void testStaticMember() {`
`27`	`31`	`Assert.assertEquals(Simple.c, 2);`
`28`	`32`	`Assert.assertEquals(x.c, 2);`
`29`	`33`	`}`
	`34`	`+`
	`35`	`+ public void testParamName() {`
	`36`	`+ Simple x = new Simple();`
	`37`	`+ x.setA(10);`
	`38`	`+ Assert.assertEquals(x.a, 10);`
	`39`	`+ }`
`30`	`40`	`}`