Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mapnik/python-mapnik
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: lightmare/python-mapnik
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 6 files changed
  • 1 contributor

Commits on Aug 14, 2019

  1. remove redundant exception translators 

    Boost.Python already knows how to translate standard C++ exceptions
into standard Python exceptions, in particular:

    std::out_of_range     => PyExc_IndexError
    std::invalid_argument => PyExc_ValueError
    std::exception        => PyExc_RuntimeError

Replace all uses of mapnik::value_error with std::invalid_argument
    @lightmare
    lightmare committed Aug 14, 2019
    Configuration menu
    Copy the full SHA
    fe3123e View commit details
    Browse the repository at this point in the history
Loading