Skip to content

Commit 24abdc3

Browse files
cztomczaklinesight
authored andcommitted
Fix CefListValue "int index" params (cztomczak#461).
1 parent f49ab60 commit 24abdc3

2 files changed

Lines changed: 21 additions & 21 deletions

File tree

src/extern/cef/cef_values.pxd

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -74,20 +74,20 @@ cdef extern from "include/cef_values.h":
7474
cpp_bool SetSize(size_t size)
7575
size_t GetSize()
7676
cpp_bool Clear()
77-
cpp_bool Remove(int index)
78-
cef_value_type_t GetType(int index)
79-
cpp_bool GetBool(int index)
80-
int GetInt(int index)
81-
double GetDouble(int index)
82-
CefString GetString(int index)
83-
CefRefPtr[CefBinaryValue] GetBinary(int index)
84-
CefRefPtr[CefDictionaryValue] GetDictionary(int index)
85-
CefRefPtr[CefListValue] GetList(int index)
86-
cpp_bool SetNull(int index)
87-
cpp_bool SetBool(int index, cpp_bool value)
88-
cpp_bool SetInt(int index, int value)
89-
cpp_bool SetDouble(int index, double value)
90-
cpp_bool SetString(int index, const CefString& value)
91-
cpp_bool SetBinary(int index, CefRefPtr[CefBinaryValue] value)
92-
cpp_bool SetDictionary(int index, CefRefPtr[CefDictionaryValue] value)
93-
cpp_bool SetList(int index, CefRefPtr[CefListValue] value)
77+
cpp_bool Remove(size_t index)
78+
cef_value_type_t GetType(size_t index)
79+
cpp_bool GetBool(size_t index)
80+
int GetInt(size_t index)
81+
double GetDouble(size_t index)
82+
CefString GetString(size_t index)
83+
CefRefPtr[CefBinaryValue] GetBinary(size_t index)
84+
CefRefPtr[CefDictionaryValue] GetDictionary(size_t index)
85+
CefRefPtr[CefListValue] GetList(size_t index)
86+
cpp_bool SetNull(size_t index)
87+
cpp_bool SetBool(size_t index, cpp_bool value)
88+
cpp_bool SetInt(size_t index, int value)
89+
cpp_bool SetDouble(size_t index, double value)
90+
cpp_bool SetString(size_t index, const CefString& value)
91+
cpp_bool SetBinary(size_t index, CefRefPtr[CefBinaryValue] value)
92+
cpp_bool SetDictionary(size_t index, CefRefPtr[CefDictionaryValue] value)
93+
cpp_bool SetList(size_t index, CefRefPtr[CefListValue] value)

src/process_message_utils.pyx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@ cdef list CefListValueToPyList(
9393
if nestingLevel > 8:
9494
raise Exception("CefListValueToPyList(): max nesting level (8)"
9595
" exceeded")
96-
cdef int index
97-
cdef int size = int(cefListValue.get().GetSize())
96+
cdef size_t index
97+
cdef size_t size = cefListValue.get().GetSize()
9898
cdef cef_types.cef_value_type_t valueType
9999
cdef list ret = []
100100
cdef CefRefPtr[CefBinaryValue] binaryValue
@@ -231,7 +231,7 @@ cdef CefRefPtr[CefListValue] PyListToCefListValue(
231231
cdef type valueType
232232
cdef CefRefPtr[CefListValue] ret = CefListValue_Create()
233233
cdef CefRefPtr[CefBinaryValue] binaryValue
234-
cdef int index
234+
cdef size_t index
235235
for index_size_t, value in enumerate(pyList):
236236
index = int(index_size_t)
237237
valueType = type(value)
@@ -288,7 +288,7 @@ cdef void PyListToExistingCefListValue(
288288
" exceeded")
289289
cdef type valueType
290290
cdef CefRefPtr[CefListValue] newCefListValue
291-
cdef int index
291+
cdef size_t index
292292
for index_size_t, value in enumerate(pyList):
293293
index = int(index_size_t)
294294
valueType = type(value)

0 commit comments

Comments
 (0)