fix: added missing mapping for ordering (LEGO#138)

gokerakc · web-flow · commit 510426e200b4 · 2023-12-14T14:53:40.000+01:00
Co-authored-by: Goker Akce &lt;goker.akce@justeattakeaway.com&gt;
diff --git a/src/LEGO.AsyncAPI.Bindings/Sns/SnsChannelBinding.cs b/src/LEGO.AsyncAPI.Bindings/Sns/SnsChannelBinding.cs
@@ -37,6 +37,7 @@ public class SnsChannelBinding : ChannelBinding<SnsChannelBinding>
         {
             { "name", (a, n) => { a.Name = n.GetScalarValue(); } },
             { "type", (a, n) => { a.Ordering = n.ParseMapWithExtensions(this.orderingFixedFields); } },
+            { "ordering", (a, n) => { a.Ordering = n.ParseMapWithExtensions(this.orderingFixedFields); } },
             { "policy", (a, n) => { a.Policy = n.ParseMapWithExtensions(this.policyFixedFields); } },
             { "tags", (a, n) => { a.Tags = n.CreateSimpleMap(s => s.GetScalarValue()); } },
         };
diff --git a/test/LEGO.AsyncAPI.Tests/Bindings/Sns/SnsBindings_Should.cs b/test/LEGO.AsyncAPI.Tests/Bindings/Sns/SnsBindings_Should.cs
@@ -1,17 +1,16 @@
-using System;
+using System.Linq;
 using LEGO.AsyncAPI.Models.Any;
 using LEGO.AsyncAPI.Models.Interfaces;
-using BindingsCollection = LEGO.AsyncAPI.Bindings.BindingsCollection;
 
 namespace LEGO.AsyncAPI.Tests.Bindings.Sns
 {
-    using NUnit.Framework;
     using System.Collections.Generic;
     using FluentAssertions;
     using LEGO.AsyncAPI.Bindings;
     using LEGO.AsyncAPI.Bindings.Sns;
     using LEGO.AsyncAPI.Models;
     using LEGO.AsyncAPI.Readers;
+    using NUnit.Framework;
 
     internal class SnsBindings_Should
     {
@@ -145,8 +144,9 @@ public void SnsChannelBinding_WithFilledObject_SerializesAndDeserializes()
 
             // Assert
             Assert.AreEqual(actual, expected);
-            binding.Should().BeEquivalentTo(channel);
-
+            
+            var expectedSnsBinding = (SnsChannelBinding)channel.Bindings.Values.First();
+            expectedSnsBinding.Should().BeEquivalentTo((SnsChannelBinding)binding.Bindings.Values.First());
         }
         
         [Test]
@@ -388,8 +388,9 @@ public void SnsOperationBinding_WithFilledObject_SerializesAndDeserializes()
 
             // Assert
             Assert.AreEqual(actual, expected);
-            binding.Should().BeEquivalentTo(operation);
-
+            
+            var expectedSnsBinding = (SnsOperationBinding)operation.Bindings.Values.First();
+            expectedSnsBinding.Should().BeEquivalentTo((SnsOperationBinding)binding.Bindings.Values.First());
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,7 @@ public class SnsChannelBinding : ChannelBinding<SnsChannelBinding>`
`37`	`37`	`{`
`38`	`38`	`{ "name", (a, n) => { a.Name = n.GetScalarValue(); } },`
`39`	`39`	`{ "type", (a, n) => { a.Ordering = n.ParseMapWithExtensions(this.orderingFixedFields); } },`
	`40`	`+ { "ordering", (a, n) => { a.Ordering = n.ParseMapWithExtensions(this.orderingFixedFields); } },`
`40`	`41`	`{ "policy", (a, n) => { a.Policy = n.ParseMapWithExtensions(this.policyFixedFields); } },`
`41`	`42`	`{ "tags", (a, n) => { a.Tags = n.CreateSimpleMap(s => s.GetScalarValue()); } },`
`42`	`43`	`};`