Skip to content

Commit e1f8c87

Browse files
VisualBeanVisualBean
committed
chore(settings)!: make reader bindings IEnumerable to allow for simpler usage
```csharp new Settings { Bindings = BindingCollection.All, }; ``` BREAKING CHANGE: changes how bindings are applied.
1 parent 1df49c8 commit e1f8c87

6 files changed

Lines changed: 10 additions & 11 deletions

File tree

‎src/LEGO.AsyncAPI.Readers/AsyncApiReaderSettings.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public Dictionary<string, Func<AsyncApiAny, IAsyncApiExtension>>
4242
{ get; set; } =
4343
new Dictionary<string, Func<AsyncApiAny, IAsyncApiExtension>>();
4444

45-
public List<IBindingParser<IBinding>>
45+
public IEnumerable<IBindingParser<IBinding>>
4646
Bindings
4747
{ get; set; } =
4848
new List<IBindingParser<IBinding>>();

‎test/LEGO.AsyncAPI.Tests/AsyncApiDocumentV2Tests.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1207,7 +1207,7 @@ public void Serialize_WithBindingReferences_SerializesDeserializes()
12071207
var actual = doc.Serialize(AsyncApiVersion.AsyncApi2_0, AsyncApiFormat.Yaml);
12081208

12091209
var settings = new AsyncApiReaderSettings();
1210-
settings.Bindings.AddRange(BindingsCollection.Pulsar);
1210+
settings.Bindings = BindingsCollection.Pulsar;
12111211
var reader = new AsyncApiStringReader(settings);
12121212
var deserialized = reader.Read(actual, out var diagnostic);
12131213
}
@@ -1300,7 +1300,7 @@ public void Serializev2_WithBindings_Serializes()
13001300
var actual = doc.Serialize(AsyncApiVersion.AsyncApi2_0, AsyncApiFormat.Yaml);
13011301

13021302
var settings = new AsyncApiReaderSettings();
1303-
settings.Bindings.AddRange(BindingsCollection.All);
1303+
settings.Bindings = BindingsCollection.All;
13041304
var reader = new AsyncApiStringReader(settings);
13051305
var deserialized = reader.Read(actual, out var diagnostic);
13061306

‎test/LEGO.AsyncAPI.Tests/Bindings/CustomBinding_Should.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public void CustomBinding_SerializesDeserializes()
111111
expected = expected.MakeLineBreaksEnvironmentNeutral();
112112

113113
var settings = new AsyncApiReaderSettings();
114-
settings.Bindings.Add(new MyBinding());
114+
settings.Bindings = new[] { new MyBinding() };
115115
var binding = new AsyncApiStringReader(settings).ReadFragment<AsyncApiChannel>(actual, AsyncApiVersion.AsyncApi2_0, out _);
116116

117117
// Assert

‎test/LEGO.AsyncAPI.Tests/Bindings/Sns/SnsBindings_Should.cs‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -136,10 +136,9 @@ public void SnsChannelBinding_WithFilledObject_SerializesAndDeserializes()
136136
actual = actual.MakeLineBreaksEnvironmentNeutral();
137137
expected = expected.MakeLineBreaksEnvironmentNeutral();
138138
var settings = new AsyncApiReaderSettings();
139-
settings.Bindings.Add(BindingsCollection.Sns);
139+
settings.Bindings = BindingsCollection.Sns;
140140
var binding = new AsyncApiStringReader(settings).ReadFragment<AsyncApiChannel>(actual, AsyncApiVersion.AsyncApi2_0, out _);
141141

142-
143142
// Assert
144143
Assert.AreEqual(actual, expected);
145144
binding.Should().BeEquivalentTo(channel);
@@ -379,7 +378,7 @@ public void SnsOperationBinding_WithFilledObject_SerializesAndDeserializes()
379378
actual = actual.MakeLineBreaksEnvironmentNeutral();
380379
expected = expected.MakeLineBreaksEnvironmentNeutral();
381380
var settings = new AsyncApiReaderSettings();
382-
settings.Bindings.Add(BindingsCollection.Sns);
381+
settings.Bindings = BindingsCollection.Sns;
383382
var binding = new AsyncApiStringReader(settings).ReadFragment<AsyncApiOperation>(actual, AsyncApiVersion.AsyncApi2_0, out _);
384383

385384

‎test/LEGO.AsyncAPI.Tests/Bindings/Sqs/SqsBindings_should.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ public void SqsChannelBinding_WithFilledObject_SerializesAndDeserializes()
213213
actual = actual.MakeLineBreaksEnvironmentNeutral();
214214
expected = expected.MakeLineBreaksEnvironmentNeutral();
215215
var settings = new AsyncApiReaderSettings();
216-
settings.Bindings.Add(BindingsCollection.Sqs);
216+
settings.Bindings = BindingsCollection.Sqs;
217217
var binding =
218218
new AsyncApiStringReader(settings).ReadFragment<AsyncApiChannel>(actual, AsyncApiVersion.AsyncApi2_0,
219219
out _);
@@ -438,7 +438,7 @@ public void SqsOperationBinding_WithFilledObject_SerializesAndDeserializes()
438438
actual = actual.MakeLineBreaksEnvironmentNeutral();
439439
expected = expected.MakeLineBreaksEnvironmentNeutral();
440440
var settings = new AsyncApiReaderSettings();
441-
settings.Bindings.Add(BindingsCollection.Sqs);
441+
settings.Bindings = BindingsCollection.Sqs;
442442
var binding = new AsyncApiStringReader(settings).ReadFragment<AsyncApiOperation>(actual, AsyncApiVersion.AsyncApi2_0, out _);
443443

444444
// Assert

‎test/LEGO.AsyncAPI.Tests/Bindings/StringOrStringList_Should.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public void StringOrStringList_WhenValueIsString_SerializesDeserializes()
8181
expected = expected.MakeLineBreaksEnvironmentNeutral();
8282

8383
var settings = new AsyncApiReaderSettings();
84-
settings.Bindings.Add(new StringOrStringListTestBinding());
84+
settings.Bindings = new[] { new StringOrStringListTestBinding() };
8585
var binding = new AsyncApiStringReader(settings).ReadFragment<AsyncApiChannel>(actual, AsyncApiVersion.AsyncApi2_0, out _);
8686

8787
// Assert
@@ -119,7 +119,7 @@ public void StringOrStringList_WhenValueIsStringList_SerializesDeserializes()
119119
expected = expected.MakeLineBreaksEnvironmentNeutral();
120120

121121
var settings = new AsyncApiReaderSettings();
122-
settings.Bindings.Add(new StringOrStringListTestBinding());
122+
settings.Bindings = new[] { new StringOrStringListTestBinding() };
123123
var binding = new AsyncApiStringReader(settings).ReadFragment<AsyncApiChannel>(actual, AsyncApiVersion.AsyncApi2_0, out _);
124124

125125
// Assert

0 commit comments

Comments
 (0)