Make MethodResponderSupplier throw Exception if no MethodResponder can respond

onlyskin · onlyskin · commit b92ffae07653 · 2018-01-12T13:46:40.000+02:00
diff --git a/src/main/java/httpserver/route/RedirectRoute.java b/src/main/java/httpserver/route/RedirectRoute.java
@@ -5,15 +5,13 @@
 import httpserver.response.FoundResponse;
 import httpserver.response.Response;
 
-import java.io.IOException;
-
 public class RedirectRoute extends Route {
     public RedirectRoute() {
         super.routeString = "/redirect";
     }
 
     @Override
-    public Response respond(AppConfig appConfig, Request request) throws IOException {
+    public Response respond(AppConfig appConfig, Request request) {
         return new FoundResponse("/");
     }
 }
diff --git a/src/test/java/httpserver/MethodRouteSupplierTest.java b/src/test/java/httpserver/MethodRouteSupplierTest.java
@@ -28,13 +28,22 @@ public MethodRouteSupplierTest() {
     @Test
     public void returnsResponderForMethod() throws Exception {
         Request request = new Request(Method.GET, null, null, null);
-        when(getResponderMock.handles(any())).thenReturn(true);
+        when(getResponderMock.handles(request)).thenReturn(true);
 
         MethodResponder methodResponder = methodResponderSupplier.supplyResponder(request);
 
         assertEquals(getResponderMock, methodResponder);
     }
 
+    @Test(expected = Exception.class)
+    public void throwsErrorWhenNoResponderForRequestMethod() throws Exception {
+        Request request = new Request(Method.PUT, null, null, null);
+        when(getResponderMock.handles(request)).thenReturn(false);
+        when(postResponderMock.handles(request)).thenReturn(false);
+
+        methodResponderSupplier.supplyResponder(request);
+    }
+
     @Test
     public void returnsAllRespondersRegistered() throws Exception {
         List<MethodResponder> actual = methodResponderSupplier.allResponders();

Original file line number	Diff line number	Diff line change
`@@ -5,15 +5,13 @@`
`5`	`5`	`import httpserver.response.FoundResponse;`
`6`	`6`	`import httpserver.response.Response;`
`7`	`7`
`8`		`-import java.io.IOException;`
`9`		`-`
`10`	`8`	`public class RedirectRoute extends Route {`
`11`	`9`	`public RedirectRoute() {`
`12`	`10`	`super.routeString = "/redirect";`
`13`	`11`	`}`
`14`	`12`
`15`	`13`	`@Override`
`16`		`- public Response respond(AppConfig appConfig, Request request) throws IOException {`
	`14`	`+ public Response respond(AppConfig appConfig, Request request) {`
`17`	`15`	`return new FoundResponse("/");`
`18`	`16`	`}`
`19`	`17`	`}`