Ensure that the Opal objects are correctly represented in Web Consoles.#2594
Draft
Ensure that the Opal objects are correctly represented in Web Consoles.#2594
Conversation
This should improve performance a little, so that we don't have to reparse the backtrace for exceptions when we don't need it.
elia
approved these changes
Oct 5, 2023
Member
elia
left a comment
There was a problem hiding this comment.
Left a couple of comments, but it already looks good 👍
| var module = constructor; | ||
| var module; | ||
| if ($truthy(name)) { | ||
| module = Function("return function "+name+" (){}")(); |
Member
There was a problem hiding this comment.
Can you add a comment explaining why we need this?
c036448 to
0756cfa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.