Skip to content

Commit 691a0f6

Browse files
committed
Fix patches and update build instructions
1 parent b05234f commit 691a0f6

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed

docs/Build-instructions.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ requirements common for all platforms.
194194
* Install packages: `sudo apt-get install cmake g++ libgtk2.0-dev libgtkglext1-dev`
195195
* If building CEF from sources:
196196
* Official binaries are built on Ubuntu 14.04 (cmake 2.8.12, g++ 4.8.4)
197-
* Download [ninja](http://martine.github.io/ninja/) 1.7.1 or later
197+
* Download [ninja](https://github.com/ninja-build/ninja/releases) 1.7.1 or later
198198
and copy it to /usr/bin and chmod 755.
199199
* Install/upgrade required packages using one of the three methods below
200200
(these packages should be upgraded each time you update to newer CEF):
@@ -223,7 +223,6 @@ requirements common for all platforms.
223223
* Download [cmake](https://cmake.org/download/) and add it to PATH.
224224

225225

226-
227226
### All platforms
228227

229228
* Install/update dependencies for the tools by executing:

patches/issue231.patch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ index 15026ab5..a3d21052 100644
115115
--- libcef_dll/wrapper/libcef_dll_wrapper.cc
116116
+++ libcef_dll/wrapper/libcef_dll_wrapper.cc
117117
@@ -880,6 +880,23 @@ CEF_GLOBAL bool CefGetPath(PathKey key, CefString& path) {
118-
return _retval?true:false;
118+
return _retval ? true : false;
119119
}
120120

121121
+CEF_GLOBAL bool CefOverridePath(PathKey key, const CefString& path) {

patches/patch.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# CEF Python patches to Chromium and CEF.
22
# See upstream cef/patch/patch.cfg for how patching works in CEF.
3-
# Current working directory is cef_build_dir/chromium/cef/ .
3+
# Current working directory is cef_build_dir/chromium/src/ .
44
# See also docs/Build-instructions.md and tools/automate.py .
55

66
import platform
@@ -12,11 +12,11 @@
1212
# ALL PLATFORMS
1313
# noinspection PyUnresolvedReferences
1414
patches.extend([
15-
{
16-
# (Disabled) Fixes HTTPS cache problems with private certificates
17-
# 'name': 'issue125',
18-
# 'path': '../net/http/'
19-
},
15+
#{
16+
# # (Disabled) Fixes HTTPS cache problems with private certificates
17+
# 'name': 'issue125',
18+
# 'path': 'net/http/'
19+
#},
2020
])
2121

2222
# LINUX
@@ -26,6 +26,6 @@
2626
{
2727
# Discovery of the "icudtl.dat" file fails on Linux.
2828
'name': 'issue231',
29-
'path': './'
29+
'path': 'cef/'
3030
},
3131
])

0 commit comments

Comments
 (0)