This commit should fix the failing tests.

sigmavirus24 · sigmavirus24 · commit 1dbd591ad126 · 2012-09-08T19:52:14.000-04:00
diff --git a/github3/git.py b/github3/git.py
@@ -83,7 +83,7 @@ def __init__(self, commit, session=None):
             self.tree = Tree(commit.get('tree'), self._session)
 
     def __repr__(self):
-        return '<Commit [{0}:{1}]>'.format(self.author.name, self._sha)
+        return '<Commit [{0}:{1}]>'.format(self.author.name, self.sha)
 
 
 class Reference(GitHubCore):
@@ -154,7 +154,7 @@ def __init__(self, tag):
         self.object = GitObject(tag.get('object'))
 
     def __repr__(self):
-        return '<Tag [{0}]>'.format(self._tag)
+        return '<Tag [{0}]>'.format(self.tag)
 
 
 class Tree(GitData):
@@ -165,15 +165,15 @@ def __init__(self, tree, session=None):
         self.tree = [Hash(t) for t in tree.get('tree', [])]
 
     def __repr__(self):
-        return '<Tree [{0}]>'.format(self._sha)
+        return '<Tree [{0}]>'.format(self.sha)
 
     def recurse(self):
         """Recurse into the tree.
 
         :returns: :class:`Tree <Tree>`
         """
-        url = self._api + '?recursive=1'
-        json = self._json(self._get(url), 200)
+        json = self._json(self._get(self._api, params={'recursive': '1'}),
+                200)
         return Tree(json, self._session) if json else None
 
 
diff --git a/tests/test_git.py b/tests/test_git.py
@@ -35,12 +35,34 @@ def test_sha(self):
     def test_size(self):
         expect_str(self.blob.size)
 
+
+class TestCommit(BaseTest):
+    def __init__(self, methodName='runTest'):
+        r = self.g.repository(self.sigm, self.todo)
+        self.commit = r.git_commit('8b0704374914f03a54b89d938de1c09d5831824e')
+
     def test_commit(self):
-        r = self.todor
-        commit = r.git_commit('8b0704374914f03a54b89d938de1c09d5831824e')
-        expect(commit).isinstance(Commit)
-        self.assertAreNotNone(commit, 'author', 'committer', 'tree', 'message',
-                'parents', 'sha')
+        expect(self.commit).isinstance(Commit)
+        expect_str(repr(self.commit))
+
+    def test_author(self):
+        expect(self.commit.author).is_not_None()
+
+    def test_committer(self):
+        expect(self.commit.author).is_not_None()
+
+    def test_tree(self):
+        expect(self.commit.tree).isinstance(Tree)
+
+    def test_message(self):
+        expect_str(self.commit.message)
+
+    def test_parents(self):
+        expect(self.commit.parents).isinstance(list)
+        self.expect_list_of_class(self.commit.parents, dict)
+
+    def test_sha(self):
+        expect_str(self.commit.sha)
 
 
 class TestTag(BaseTest):
@@ -74,6 +96,8 @@ def __init__(self, methodName='runTest'):
         super(TestTreeHash, self).__init__(methodName)
         r = self.g.repository(self.sigm, self.todo)
         self.tree = r.tree('31e862095dffa60744f1ce16a431ea040381f053')
+        self.hashes = self.tree.tree
+        self.hash = self.hashes[0]
 
     def test_tree(self):
         expect(self.tree).isinstance(Tree)
@@ -86,10 +110,8 @@ def test_tree_recurse(self):
         expect(self.tree.recurse()).isinstance(Tree)
 
     def test_hash(self):
-        self.hashes = self.tree.tree
         for h in self.hashes:
             expect(h).isinstance(Hash)
-        self.hash = self.hashes[0]
 
     def test_hash_mode(self):
         expect_str(self.hash.mode)
