Assign to _api property instead of strorign slug

westphahl · westphahl · commit b78586ff68e1 · 2019-01-14T15:49:29.000+01:00
diff --git a/src/github3/checks.py b/src/github3/checks.py
@@ -114,13 +114,8 @@ def _update_attributes(self, app):
         self.id = app["id"]
         self.name = app["name"]
         self.owner = app["owner"]
-        _, self.slug = app["html_url"].rsplit("/", 1)
-
-    @property
-    def url(self):
-        return self._build_url("apps", self.slug)
-
-    _api = url
+        _, slug = app["html_url"].rsplit("/", 1)
+        self._api = self.url = self._build_url("apps", slug)
 
     def _repr(self):
         return '<App ["{}" by {}]>'.format(
@@ -138,7 +133,7 @@ def to_app(self):
         from . import apps
 
         headers = getattr(self, "CUSTOM_HEADERS", None)
-        json = self._json(self._get(self.url, headers=headers), 200)
+        json = self._json(self._get(self._api, headers=headers), 200)
         return self._instance_or_null(apps.App, json)
 
     refresh = to_app
diff --git a/tests/unit/helper.py b/tests/unit/helper.py
@@ -90,6 +90,7 @@ def create_session_mock(self, *args):
         session.post.return_value = None
         session.put.return_value = None
         session.has_auth.return_value = True
+        session.build_url = self.get_build_url_proxy()
         return session
 
     def create_instance_of_described_class(self):
@@ -213,6 +214,7 @@ class has a dummy ``__iter__`` implementation which we want for
         session.patch.return_value = null
         session.post.return_value = null
         session.put.return_value = null
+        session.build_url = self.get_build_url_proxy()
         return session
 
     def get_next(self, iterator):
