chore(ui): upgrade react-resizable-panels to v4#501
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Ilya Boyandin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
@sqlrooms/uiup to the latestreact-resizable-panels(v4) and align the wrapper with the v4 API and shadcn v4 guidance to avoid runtime/type errors and keep the public wrapper stable for consumers.directionprop and numeric size semantics to the new v4 primitives and prop shapes.Description
react-resizable-panelsdependency inpackages/ui/package.jsonfrom^3.0.6to^4.7.6and updated the lockfile.packages/ui/src/components/resizable.tsxto use v4 primitives:Group,Panel, andSeparatorinstead of the oldPanelGroup/PanelResizeHandlenames.directionto v4orientationand converts numeric size props (defaultSize,minSize,maxSize,collapsedSize) to percent strings so existing callsites continue to behave.data-[panel-group-direction=vertical]attribute toaria-orientationselectors to match v4 semantics.Testing
pnpm buildbefore changes which surfaced v4 API/type errors in the UI wrapper (expected failure), and then ranpnpm buildafter the wrapper update which completed successfully.pnpm view react-resizable-panels versionto confirm the target release (4.7.6).prettierformatting) ran automatically during the commit and passed.Codex Task