Fix rubocop offenses

mbj · mbj · commit 250e8b166b07 · 2015-06-13T19:22:38.000Z
diff --git a/config/rubocop.yml b/config/rubocop.yml
@@ -72,10 +72,6 @@ ConstantName:
 TrivialAccessors:
   Enabled: false
 
-# Do not prefer do/end over {} for multiline blocks
-Blocks:
-  Enabled: false
-
 # I like to have an empty line before closing the currently opened body
 EmptyLinesAroundBlockBody:
   Enabled: false
diff --git a/lib/unparser/cli.rb b/lib/unparser/cli.rb
@@ -38,7 +38,8 @@ def self.run(*arguments)
     # @api private
     #
     def initialize(arguments)
-      @sources, @ignore = [], Set.new
+      @sources = []
+      @ignore = Set.new
 
       @success   = true
       @fail_fast = false
diff --git a/lib/unparser/emitter/class.rb b/lib/unparser/emitter/class.rb
@@ -41,7 +41,7 @@ def emit_superclass
     end # Class
 
     # Emitter for sclass nodes
-    class SClass  < self
+    class SClass < self
       include Terminated
 
       handle :sclass
diff --git a/lib/unparser/emitter/send/unary.rb b/lib/unparser/emitter/send/unary.rb
@@ -4,6 +4,9 @@ module Unparser
   class Emitter
     class Send
       # Emitter for unary sends
+      #
+      # rubocop:disable Style/HashSyntax
+      # ^^ is false positive
       class Unary < self
         include Unterminated
 
diff --git a/spec/integration/unparser/corpus_spec.rb b/spec/integration/unparser/corpus_spec.rb
@@ -2,6 +2,7 @@
 
 require 'spec_helper'
 
+# rubocop:disable ClosingParenthesisIndentation
 describe 'Unparser on ruby corpus' do
   before do
     if RUBY_VERSION < '2.1.0'
diff --git a/spec/unit/unparser_spec.rb b/spec/unit/unparser_spec.rb
@@ -30,7 +30,7 @@ def assert_round_trip(input, parser)
       ast, comments = parser.parse_with_comments(input)
       generated = Unparser.unparse(ast, comments)
       expect(generated).to eql(input)
-      generated_ast, _ = parser.parse_with_comments(generated)
+      generated_ast, _comments = parser.parse_with_comments(generated)
       expect(ast == generated_ast).to be(true)
     end
 

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,8 @@ def self.run(*arguments)`
`38`	`38`	`# @api private`
`39`	`39`	`#`
`40`	`40`	`def initialize(arguments)`
`41`		`- @sources, @ignore = [], Set.new`
	`41`	`+ @sources = []`
	`42`	`+ @ignore = Set.new`
`42`	`43`
`43`	`44`	`@success = true`
`44`	`45`	`@fail_fast = false`