Closed
Bug 1998245
Opened 4 months ago
Closed 2 months ago
[css-attr] Implement support for <number> and `<attr-unit>`.
Categories
(Core :: CSS Parsing and Computation, task)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
148 Branch
| Tracking | Status | |
|---|---|---|
| firefox148 | --- | fixed |
People
(Reporter: dshin, Assigned: sukil)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, Whiteboard: css-attr, [wptsync upstream])
Attachments
(1 file)
<number> unit parsing should hopefully be straightforward - ensuring that the specified attribute can be parsed as a number.
<attr-unit> e.g. attr(foo px) is basically parsing as number, then making it a type of that unit. We should also ensure that the type is suitable for the property, e.g. background-color: attr(len px);.
|
Reporter | |
Comment 1•4 months ago
|
||
We should also ensure that the type is suitable for the property, e.g. background-color: attr(len px);.
That should be covered automatically since we create a string based on the result of substitution and the property is parsed from that, here.
Keywords: dev-doc-needed
|
Assignee | |
Updated•2 months ago
|
Assignee: nobody → sukil
|
|
Assignee | |
Comment 2•2 months ago
|
||
Pushed by sukil@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/0ab0e71fbce0
https://hg.mozilla.org/integration/autoland/rev/c9dd42b395ee
Implement support for <number> and <attr-unit>. r=emilio,firefox-style-system-reviewers
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/57114 for changes under testing/web-platform/tests
Whiteboard: css-attr → css-attr, [wptsync upstream]
|
||
Comment 5•2 months ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox148:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 148 Branch
Upstream PR merged by moz-wptsync-bot
|
||
Updated•2 months ago
|
QA Whiteboard: [qa-triage-done-c149/b148]
|
||
Comment 7•11 days ago
|
||
Related issues and pull requests
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•