Skip to content

Commit 4558ead

Browse files
Ahmad-S792Ahmad Saleem
Ahmad-S792
authored and
Ahmad Saleem
committed
Remove HTMLHeadElement.profile
Remove HTMLHeadElement.profile https://bugs.webkit.org/show_bug.cgi?id=249896 Reviewed by Ryosuke Niwa. This patch is to align with Web-Specifications and other browser engines by removing 'profile' attribute support. The patch removes "profile" attribute from 'head' element, which was removed from HTML Specifications in 2010 and later dropped by browsers as far back as 2014. Currently, only Safari / WebKit support this. * Source/WebCore/html/HTMLHeadElement.idl: Remove 'profile' * Source/WebCore/html/HTMLAttributeNames.in: Remove 'profile' * Source/WebKitLegacy/mac/DOM/DOMHTMLHeadElement.mm: Return null for 'profileAttr' & early return for setProfile function * Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLHeadElement.cpp: (webkit_dom_html_head_element_get_profile): Return 'nullptr' (webkit_dom_html_head_element_set_profile): Early return * LayoutTests/fast/dom/element-attribute-js-null.html: Rebaselined * LayoutTests/fast/dom/element-attribute-js-null-expected.txt: Rebaselined * LayoutTests/dom/xhtml/level2/html/HTMLHeadElement01.xhtml: Removed * LayoutTests/dom/xhtml/level2/html/HTMLHeadElement01.js: Ditto * LayoutTests/dom/xhtml/level2/html/HTMLHeadElement01-expected.txt: Ditto * LayoutTests/dom/html/level2/html/HTMLHeadElement01.html: Removed * LayoutTests/dom/html/level2/html/HTMLHeadElement01.js: Ditto * LayoutTests/dom/html/level2/html/HTMLHeadElement01-expected.txt: Ditto Canonical link: https://commits.webkit.org/258397@main
1 parent 64ad5fc commit 4558ead

File tree

12 files changed

+6
-274
lines changed

12 files changed

+6
-274
lines changed

‎LayoutTests/dom/html/level2/html/HTMLHeadElement01-expected.txt‎

Lines changed: 0 additions & 2 deletions
This file was deleted.

‎LayoutTests/dom/html/level2/html/HTMLHeadElement01.html‎

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎LayoutTests/dom/html/level2/html/HTMLHeadElement01.js‎

Lines changed: 0 additions & 113 deletions
This file was deleted.

‎LayoutTests/dom/xhtml/level2/html/HTMLHeadElement01-expected.txt‎

Lines changed: 0 additions & 2 deletions
This file was deleted.

‎LayoutTests/dom/xhtml/level2/html/HTMLHeadElement01.js‎

Lines changed: 0 additions & 113 deletions
This file was deleted.

‎LayoutTests/dom/xhtml/level2/html/HTMLHeadElement01.xhtml‎

Lines changed: 0 additions & 13 deletions
This file was deleted.

‎LayoutTests/fast/dom/element-attribute-js-null-expected.txt‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,6 @@ TEST SUCCEEDED: The value was the string 'null'. [tested HTMLFrameElement.scroll
7272
TEST SUCCEEDED: The value was the string 'null'. [tested HTMLFrameSetElement.cols]
7373
TEST SUCCEEDED: The value was the string 'null'. [tested HTMLFrameSetElement.rows]
7474

75-
TEST SUCCEEDED: The value was the string 'null'. [tested HTMLHeadElement.profile]
76-
7775
TEST SUCCEEDED: The value was the string 'null'. [tested HTMLHeadingElement.align]
7876

7977
TEST SUCCEEDED: The value was the string 'null'. [tested HTMLHRElement.align]

‎LayoutTests/fast/dom/element-attribute-js-null.html‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -224,13 +224,6 @@
224224
{name: 'rows', expectedNull: 'null'}
225225
]
226226
},
227-
{
228-
type: 'HTMLHeadElement',
229-
elementToUse: document.createElement('head'),
230-
attributes: [
231-
{name: 'profile', expectedNull: 'null'}
232-
]
233-
},
234227
{
235228
type: 'HTMLHeadingElement',
236229
// no need to test h2-h6

‎Source/WebCore/html/HTMLAttributeNames.in‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,6 @@ poster
367367
precision
368368
preload
369369
primary
370-
profile
371370
progress
372371
prompt
373372
pseudo

‎Source/WebCore/html/HTMLHeadElement.idl‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (C) 2006, 2010 Apple Inc. All rights reserved.
2+
* Copyright (C) 2006-2022 Apple Inc. All rights reserved.
33
*
44
* This library is free software; you can redistribute it and/or
55
* modify it under the terms of the GNU Library General Public
@@ -20,6 +20,5 @@
2020
[
2121
Exposed=Window
2222
] interface HTMLHeadElement : HTMLElement {
23-
[Reflect] attribute DOMString profile;
2423
};
2524

0 commit comments

Comments
 (0)