AX: VoiceOver hangs in Safari when selecting "Sign in with Apple" on kickstarter.com and elsewhere

twilco · twilco · commit 059da518e6c0 · 2023-01-20T10:26:06.000-08:00
https://bugs.webkit.org/show_bug.cgi?id=250867 rdar://problem/104449619 Reviewed by Chris Fleizach. "Sign in with Apple" on kickstarter.com triggers sync IPC through WebChromeClient::createWindow. Depending on how the client handles this request, this IPC may not return for an arbitrary amount of time. In this case, Safari opens a native dialog, and the sync IPC does not return until the dialog is closed. This causes web content to become unresponsive to VoiceOver because the main-thread is hung. This patch fixes this by using IPC::SendSyncOption::InformPlatformProcessWillSuspend to tell VoiceOver we will become unresponsive until the IPC completes. I couldn't find a good way to test this in an automated fashion. * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::createWindow): Canonical link: https://commits.webkit.org/259147@main
diff --git a/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp b/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
@@ -332,7 +332,7 @@ Page* WebChromeClient::createWindow(Frame& frame, const WindowFeatures& windowFe
 
     WebFrame* webFrame = WebFrame::fromCoreFrame(frame);
 
-    auto sendResult = webProcess.parentProcessConnection()->sendSync(Messages::WebPageProxy::CreateNewPage(webFrame->info(), webFrame->page()->webPageProxyIdentifier(), navigationAction.resourceRequest(), windowFeatures, navigationActionData), m_page.identifier(), IPC::Timeout::infinity(), IPC::SendSyncOption::MaintainOrderingWithAsyncMessages);
+    auto sendResult = webProcess.parentProcessConnection()->sendSync(Messages::WebPageProxy::CreateNewPage(webFrame->info(), webFrame->page()->webPageProxyIdentifier(), navigationAction.resourceRequest(), windowFeatures, navigationActionData), m_page.identifier(), IPC::Timeout::infinity(), { IPC::SendSyncOption::MaintainOrderingWithAsyncMessages, IPC::SendSyncOption::InformPlatformProcessWillSuspend });
     if (!sendResult)
         return nullptr;
 
