[@Property] Check for computational dependencies in transform functions

anttijk · anttijk · commit ba49d5d8bb0b · 2023-01-25T07:24:27.000-08:00
https://bugs.webkit.org/show_bug.cgi?id=251141 rdar://104553316 Reviewed by Tim Nguyen. trasnlateX(1em) is not computationally independent and can't be used as an initial value. * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property.html: * Source/WebCore/css/CSSValue.cpp: (WebCore::CSSValue::collectComputedStyleDependencies const): Collect from function argument lists. Canonical link: https://commits.webkit.org/259353@main
diff --git a/LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-expected.txt
@@ -56,6 +56,10 @@ PASS Rule not applied [<gandalf>, grey, false]
 PASS Rule not applied [gandalf, grey, false]
 PASS Rule not applied [<color>, notacolor, false]
 PASS Rule not applied [<length>, 10em, false]
+PASS Rule not applied [<transform-function>, translateX(1em), false]
+PASS Rule not applied [<transform-function>, translateY(1lh), false]
+PASS Rule not applied [<transform-list>, rotate(10deg) translateX(1em), false]
+PASS Rule not applied [<transform-list>, rotate(10deg) translateY(1lh), false]
 PASS Non-inherited properties do not inherit
 PASS Inherited properties inherit
 PASS Initial values substituted as computed value
diff --git a/LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property.html b/LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property.html
@@ -148,6 +148,11 @@
 test_not_applied('<color>', 'notacolor', false);
 test_not_applied('<length>', '10em', false);
 
+test_not_applied('<transform-function>', 'translateX(1em)', false);
+test_not_applied('<transform-function>', 'translateY(1lh)', false);
+test_not_applied('<transform-list>', 'rotate(10deg) translateX(1em)', false);
+test_not_applied('<transform-list>', 'rotate(10deg) translateY(1lh)', false);
+
 // Inheritance
 
 test_with_at_property({
diff --git a/Source/WebCore/css/CSSValue.cpp b/Source/WebCore/css/CSSValue.cpp
@@ -236,9 +236,13 @@ void CSSValue::collectComputedStyleDependencies(ComputedStyleDependencies& depen
             listValue->collectComputedStyleDependencies(dependencies);
         return;
     }
-
-    if (is<CSSPrimitiveValue>(*this))
-        downcast<CSSPrimitiveValue>(*this).collectComputedStyleDependencies(dependencies);
+    if (auto* asFunction = dynamicDowncast<CSSFunctionValue>(*this)) {
+        for (auto& argument : *asFunction)
+            argument->collectComputedStyleDependencies(dependencies);
+        return;
+    }
+    if (auto* asPrimitiveValue = dynamicDowncast<CSSPrimitiveValue>(*this))
+        asPrimitiveValue->collectComputedStyleDependencies(dependencies);
 }
 
 bool CSSValue::equals(const CSSValue& other) const
