Unreviewed, reverting 284017@main.

webkit-commit-queue · pvollan · commit ee2a2fb2db8c · 2024-09-24T07:26:25.000-07:00
https://bugs.webkit.org/show_bug.cgi?id=280270 Introduced unexpected download failure in some scenarios Reverted changeset: "The download should fail if we don't get a placeholder URL" https://bugs.webkit.org/show_bug.cgi?id=280079 https://commits.webkit.org/284017@main Canonical link: https://commits.webkit.org/284157@main
diff --git a/Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm b/Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm
@@ -169,10 +169,8 @@
 
 void Download::setPlaceholderURL(NSURL *placeholderURL, NSData *bookmarkData)
 {
-    if (!placeholderURL) {
-        didFail({ }, { });
+    if (!placeholderURL)
         return;
-    }
 
     m_placeholderURL = placeholderURL;
 

Original file line number	Diff line number	Diff line change
`@@ -169,10 +169,8 @@`
`169`	`169`
`170`	`170`	`void Download::setPlaceholderURL(NSURL placeholderURL, NSData bookmarkData)`
`171`	`171`	`{`
`172`		`- if (!placeholderURL) {`
`173`		`- didFail({ }, { });`
	`172`	`+ if (!placeholderURL)`
`174`	`173`	`return;`
`175`		`- }`
`176`	`174`
`177`	`175`	`m_placeholderURL = placeholderURL;`
`178`	`176`