Crash under WebAutomationSession::platformSimulateMouseInteraction when running pointerevents/pointerevent_click_during_capture.html?mouse-auxclick WPT

lilyspiniolas · lilyspiniolas · commit 07e1827a1251 · 2024-10-02T14:25:44.000-07:00
https://bugs.webkit.org/show_bug.cgi?id=280768 rdar://137068514 Reviewed by Aditya Keerthi and Abrar Rahman Protyasha. Abrar Protyasha determined that web-platform-test 'pointerevent_click_during_capture.html?mouse-auxclick' is crashing due to dragEventType not getting updated when a right click is simulated in WebAutomationSession::platformSimulateMouseInteraction. This causes an NSEvent instantiation with an NSEventType of 0, resulting in a crash. Adding this missing update fixes the test crash. * Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm: (WebKit::WebAutomationSession::platformSimulateMouseInteraction): Canonical link: https://commits.webkit.org/284577@main
diff --git a/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm b/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm
@@ -221,6 +221,7 @@ static WebMouseEventButton automationMouseButtonToPlatformMouseButton(MouseButto
         break;
     case WebMouseEventButton::Right:
         downEventType = NSEventTypeRightMouseDown;
+        dragEventType = NSEventTypeRightMouseDragged;
         upEventType = NSEventTypeRightMouseUp;
         break;
     }

Original file line number	Diff line number	Diff line change
`@@ -221,6 +221,7 @@ static WebMouseEventButton automationMouseButtonToPlatformMouseButton(MouseButto`
`221`	`221`	`break;`
`222`	`222`	`case WebMouseEventButton::Right:`
`223`	`223`	`downEventType = NSEventTypeRightMouseDown;`
	`224`	`+ dragEventType = NSEventTypeRightMouseDragged;`
`224`	`225`	`upEventType = NSEventTypeRightMouseUp;`
`225`	`226`	`break;`
`226`	`227`	`}`