REGRESSION(294019@main): input field does not show user input while user is actively typing

alanbaradlay · alanbaradlay · commit 638f071fee17 · 2025-12-11T12:09:10.000-08:00
https://bugs.webkit.org/show_bug.cgi?id=304001 <rdar://163613957> Reviewed by Antti Koivisto. Let's loosen up isContentConsideredStale a bit so that we still paint inline content even when an out-of-flow box is dirty. Normally we would bail out on needsLayout (see FIXME), but it is reasonable to exclude non-inflow (and by definition non-inline) content here. Test: fast/inline/missing-content-on-autofill-with-out-of-flow-input-descendant.html * LayoutTests/TestExpectations: * LayoutTests/fast/inline/missing-content-on-autofill-with-out-of-flow-input-descendant-expected.html: Added. * LayoutTests/fast/inline/missing-content-on-autofill-with-out-of-flow-input-descendant.html: Added. * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::isContentConsideredStale const): Canonical link: https://commits.webkit.org/304311@main
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
@@ -8155,6 +8155,8 @@ imported/w3c/web-platform-tests/css/css-viewport/zoom/border-spacing.html [ Imag
 imported/w3c/web-platform-tests/css/css-viewport/zoom/border-width.html [ ImageOnlyFailure ]
 imported/w3c/web-platform-tests/css/css-viewport/zoom/border.html [ ImageOnlyFailure ]
 
+# RenderTreeNeedsLayoutChecker hits.
+webkit.org/b/304002 [ Debug ] fast/inline/missing-content-on-autofill-with-out-of-flow-input-descendant.html [ Skip ]
 
 # Hits assert in debug, tracked by https://bugs.webkit.org/show_bug.cgi?id=303414
 [ Debug ] fullscreen/fullscreen-grid-item-container-type-crash.html [ Skip ]
diff --git a/LayoutTests/fast/inline/missing-content-on-autofill-with-out-of-flow-input-descendant-expected.html b/LayoutTests/fast/inline/missing-content-on-autofill-with-out-of-flow-input-descendant-expected.html
@@ -0,0 +1,22 @@
+<!DOCTYPE html>
+<style>
+.form-element {
+    position: relative;
+}
+
+.form-textbox {
+	height: 200px;
+}
+</style>
+<div class=form-element>
+  <input class=form-textbox type="text" value="Text">
+</div>
+<script>
+if (window.testRunner) {
+	testRunner.waitUntilDone();
+	eventSender.mouseMoveTo(10, 10);
+	eventSender.mouseDown();
+	eventSender.mouseUp();
+	testRunner.notifyDone();
+}
+</script>
diff --git a/LayoutTests/fast/inline/missing-content-on-autofill-with-out-of-flow-input-descendant.html b/LayoutTests/fast/inline/missing-content-on-autofill-with-out-of-flow-input-descendant.html
@@ -0,0 +1,29 @@
+<!DOCTYPE html>
+<style>
+.form-element {
+    position: relative;
+}
+
+.form-textbox::-webkit-contacts-auto-fill-button {
+    position: absolute;
+    left: 110px;
+    visibility: hidden;
+}
+
+.form-textbox {
+	height: 200px;
+}
+</style>
+<div class=form-element>
+  <input id=auto_fill_this class=form-textbox type="text" value="Text">
+</div>
+<script>
+if (window.testRunner) {
+	window.internals.setAutofillButtonType(document.getElementById("auto_fill_this"), "Contacts");
+	testRunner.waitUntilDone();
+	eventSender.mouseMoveTo(10, 10);
+	eventSender.mouseDown();
+	eventSender.mouseUp();
+	testRunner.notifyDone();
+}
+</script>
diff --git a/Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp b/Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
@@ -1158,8 +1158,10 @@ bool LineLayout::isContentConsideredStale() const
     auto* rootRenderer = m_rootLayoutBox->rendererForIntegration();
     if (!rootRenderer)
         return true;
-    if (rootRenderer->needsLayout())
+    if (rootRenderer->normalChildNeedsLayout()) {
+        // FIXME: Let's bail out on needsLayout() -see webkit.org/b/304002
         return true;
+    }
     if (rootRenderer->style().isSkippedRootOrSkippedContent())
         return true;
     if (m_lineDamage && m_lineDamage->hasDetachedContent())
